From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Reduce the number of files probed when finding a lisp file. Date: Tue, 02 Jun 2020 16:24:43 +0000 Message-ID: References: <83blm1eciw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98311"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: nicolasbertolo@gmail.com, 41242@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 02 18:27:57 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jg9ld-000PTQ-Hy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jun 2020 18:27:57 +0200 Original-Received: from localhost ([::1]:58186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg9lc-0001wB-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jun 2020 12:27:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg9io-0008LA-NR for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 12:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jg9io-00084y-Bb for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 12:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jg9io-0001SU-7f for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 12:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jun 2020 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.15911150905582 (code B ref 41242); Tue, 02 Jun 2020 16:25:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 2 Jun 2020 16:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:40745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg9ib-0001Ry-RA for submit@debbugs.gnu.org; Tue, 02 Jun 2020 12:24:50 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:52290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg9iY-0001Rn-I8 for 41242@debbugs.gnu.org; Tue, 02 Jun 2020 12:24:48 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 052GOitD021425 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 2 Jun 2020 16:24:44 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 052GOhbT015715; Tue, 2 Jun 2020 16:24:43 GMT In-Reply-To: <83blm1eciw.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jun 2020 18:02:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181411 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: 41242@debbugs.gnu.org, Eli Zaretskii >> Date: Mon, 01 Jun 2020 19:24:43 +0000 >> >> In which folders are we going to search if we do (load "...a/path/foo.eln")? >> >> I believe in this case we should search the file only in "...a/path/" >> because the user really want to load this specific file. Am I correct? > > Isn't that already so when we look for *.elc files? Yes but here the hash directory that we use to disambiguate the triplet comes into play so we search there too. This is what Nico posted about what we would probe for a load. (load "C:/dir/foo.eln") "c:/dir/foo.eln.eln" "c:/dir/eln-hash/foo.eln.eln" "c:/dir/foo.eln.dll" "c:/dir/foo.eln.elc" "c:/dir/foo.eln.elc.gz" "c:/dir/foo.eln.el" "c:/dir/foo.eln.el.gz" "c:/dir/foo.eln" "c:/dir/foo.eln.gz" My argument was that in the case of (load "C:/dir/foo.eln") we should try to load only "c:/dir/foo.eln" without having to look into "c:/dir/eln-hash/". But Nico pointed out (probably correctly) that the function is already quite dumb regarding ignoring extentions and is probably not worth doing an exception for this. >> That said IMO this logic is sufficiently complex to deserve a minimum of >> testing to make sure we have it under control. Not sure if the best >> place is files-tests.el or comp-tests.el. >> >> Maybe Eli likes to gives his opinion on this last point and on the patch >> in general. > > I think the logic should be consistent with how we search for Lisp > files in general. > -- akrl@sdf.org