From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45443: 28.0.50; Can't find definition of compilation--message->loc Date: Sun, 27 Dec 2020 17:59:09 +0000 Message-ID: References: > <83a6u0n8y7.fsf@gnu.org>> <83lfdjkuzd.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11830"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel =?UTF-8?Q?Mart=C3=ADn?= , rms@gnu.org, 45443@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 27 19:00:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktaKx-0002tB-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 19:00:11 +0100 Original-Received: from localhost ([::1]:39756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktaKv-00045o-Tu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 13:00:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktaKp-00045f-2c for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktaKo-0002Iv-Pt for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktaKo-0007hs-O3 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 13:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2020 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 45443-submit@debbugs.gnu.org id=B45443.160909196029551 (code B ref 45443); Sun, 27 Dec 2020 18:00:02 +0000 Original-Received: (at 45443) by debbugs.gnu.org; 27 Dec 2020 17:59:20 +0000 Original-Received: from localhost ([127.0.0.1]:33485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktaK7-0007gZ-W3 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 12:59:20 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:53908 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktaK4-0007gQ-JK for 45443@debbugs.gnu.org; Sun, 27 Dec 2020 12:59:18 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1ktaJy-0003YO-2J; Sun, 27 Dec 2020 17:59:10 +0000 In-Reply-To: <83lfdjkuzd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Dec 2020 19:40:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196812 Archived-At: Eli Zaretskii writes: >> From: Daniel Mart=C3=ADn >> Cc: Eli Zaretskii , rms@gnu.org, 45443@debbugs.gnu.org >> Date: Sun, 27 Dec 2020 01:51:29 +0100 >>=20 >> One possible approach is, if the regular expression code fails to find a >> location, we can fall back to expand macros until we find the definition >> (a defalias in the case of a function, or a defvar in the case of a >> variable), or we reach the end of the file. > > Why do we need to expand macros? isn't it enough to find the defstruct > itself, by looking for a partial match? I haven't look at the patch, but I think the approach of macro expanding is more general as should be able to track any function definition that is synthesized by any macro. Andrea