From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46983: 28.0.50; [feature/native] Allow .el files to specify non-default values for native-compilation options Date: Sun, 07 Mar 2021 20:28:44 +0000 Message-ID: References: <83zgzftt5t.fsf@gnu.org> <83wnuisooy.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46983@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 21:29:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJ01U-000ASh-2m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 21:29:08 +0100 Original-Received: from localhost ([::1]:59020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJ01T-0000oS-5X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 15:29:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJ01N-0000mx-Vl for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 15:29:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJ01N-0007Wb-O7 for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 15:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJ01N-0007wn-Ld for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 15:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46983 X-GNU-PR-Package: emacs Original-Received: via spool by 46983-submit@debbugs.gnu.org id=B46983.161514892830529 (code B ref 46983); Sun, 07 Mar 2021 20:29:01 +0000 Original-Received: (at 46983) by debbugs.gnu.org; 7 Mar 2021 20:28:48 +0000 Original-Received: from localhost ([127.0.0.1]:41596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ019-0007wL-Ur for submit@debbugs.gnu.org; Sun, 07 Mar 2021 15:28:48 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:62486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ018-0007wC-28 for 46983@debbugs.gnu.org; Sun, 07 Mar 2021 15:28:46 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 127KSiRo028652 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 7 Mar 2021 20:28:45 GMT In-Reply-To: <83wnuisooy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Mar 2021 22:18:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201778 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: Eli Zaretskii , 46983@debbugs.gnu.org >> Date: Sun, 07 Mar 2021 19:35:01 +0000 >> >> Okay dbdc44db15 should allow for `comp-native-driver-options' as >> file-local to be captured correctly. > > Thanks. > >> I've only added 'gcc_jit_context_add_driver_option' to GCC 9 so we have >> to decide what to do when this is not available on older GCC. >> >> Till today we raised an error as the use of `comp-native-driver-options' >> was a deliberate user choice and it's effectiveness was testable with >> `comp-native-driver-options-effective-p', but if this becomes part of >> source code we should probably transition to a warining? WDYT? > > I'd say, if this is set in file-local variables, just ignore the > setting if it cannot be applied. Is this possible to ignore it in > file-local vars, but still signal an error if customized? Right we can handle the two cases separately, doing it. Andrea