From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Tue, 09 Mar 2021 17:04:58 +0000 Message-ID: References: <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> <83tupms4mp.fsf@gnu.org> <83eegpspjk.fsf@gnu.org> <83r1kpr03h.fsf@gnu.org> <83h7llqslb.fsf@gnu.org> <834khkqttt.fsf@gnu.org> <83v9a0p8y0.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13228"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 20:08:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJhiN-0003LP-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 20:08:19 +0100 Original-Received: from localhost ([::1]:37036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJhiM-0005Fj-5N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 14:08:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJfo2-0005ZV-C3 for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJfo2-0000rI-1f for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJfo1-00041p-SP for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161530950515412 (code B ref 46256); Tue, 09 Mar 2021 17:06:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 9 Mar 2021 17:05:05 +0000 Original-Received: from localhost ([127.0.0.1]:47826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfn7-00040W-Az for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:05:05 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:62773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfn4-000400-85 for 46256@debbugs.gnu.org; Tue, 09 Mar 2021 12:05:03 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 129H4xLt013244 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Mar 2021 17:04:59 GMT In-Reply-To: <83v9a0p8y0.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Mar 2021 18:51:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201925 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: pipcet@gmail.com, 46256@debbugs.gnu.org, andrewjmoreton@gmail.com >> Date: Tue, 09 Mar 2021 15:38:54 +0000 >> >> > I've now built the latest branch. It still crashes, in the same >> > place, although with different Lisp files. I'm looking into this, >> > will post the details. >> >> Thinking about, you might have stale eln files reachable in the >> `comp-eln-load-path' generated with the bug fixed by 380ba045c4. > > Maybe. What I see is that we load a CU in Fnative_elisp_load followed > by load_comp_unit, for the first time, and create a Lisp CU object for > it: > > Lisp_Object comp_u_lisp_obj; > XSETNATIVE_COMP_UNIT (comp_u_lisp_obj, comp_u); > > Then we store it in the shared library: > > if (comp_u->loaded_once) > ... > else > *saved_cu = comp_u_lisp_obj; > > But then we clobber the value of comp_u_lisp_obj here: > > data_ephemeral_vec = > load_static_obj (comp_u, TEXT_DATA_RELOC_EPHEMERAL_SYM); > > EMACS_INT d_vec_len = XFIXNUM (Flength (data_ephemeral_vec)); > for (EMACS_INT i = 0; i < d_vec_len; i++) > data_eph_relocs[i] = AREF (data_ephemeral_vec, i); <<<<<<<<<<< > > Is this likely to be due to that problem? Interesting, how can we clobber the value of 'comp_u_lisp_obj' that is stack allocated while writing into 'data_eph_relocs[i]' that is static allocated in an eln? If we clobber 'comp_u_lisp_obj' this is certanly a problem as we have to pass it to 'top_level_run' later on. Thanks Andrea