From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 14:35:43 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83im6o2n67.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8776"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , larsi@gnus.org, 43725@debbugs.gnu.org, Stefan Monnier To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 15:36:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD6tA-0002BF-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 15:36:12 +0100 Original-Received: from localhost ([::1]:42904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD6t9-0003jh-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 09:36:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD6t0-0003hq-6m for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD6sz-0007b4-UZ for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD6sz-0002xa-RJ for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 09:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161374534911360 (code B ref 43725); Fri, 19 Feb 2021 14:36:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 14:35:49 +0000 Original-Received: from localhost ([127.0.0.1]:49033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD6sm-0002xA-V8 for submit@debbugs.gnu.org; Fri, 19 Feb 2021 09:35:49 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:54250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD6sj-0002wz-9W for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 09:35:47 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11JEZhqB018016 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 19 Feb 2021 14:35:44 GMT In-Reply-To: (Pip Cet's message of "Fri, 19 Feb 2021 14:23:05 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200340 Archived-At: Pip Cet writes: > On Fri, Feb 19, 2021 at 2:16 PM Andrea Corallo wrote: >> >> > comp.c:1174:22: warning: logical =E2=80=98or=E2=80=99 of collective= ly exhaustive tests is always true [-Wlogical-op] >> >> > 1174 | if (val > LONG_MAX || val < LONG_MIN) >> >> > | ^~ >> >> > >> >> > Not sure what's the best way to silence it or if we want to revert = to >> >> > the previous formulation. >> >> >> >> Maybe it's me, but I had a hard time parsing that warning. IIUC, the >> >> tests are both trivially false? And oring two trivially false >> >> conditions shouldn't trigger a warning, should it? >> > >> > No, I think it tries to say that val is always either greater than >> > LONG_MAX or smaller than LONG_MIN. >> >> Exactly, the warning is about the fact that all the other conditions >> will never be evaluated. The phrasing is admittedly quite cryptic tho. > > I thought you said this was a setup where the argument _does_ fit a long? There we are dispatching if 'val' can be expressed or not with a long. 'val' is an EMACS_INT so depending on the configuration it might fit in a long by definition, when this happen GCC sees the first condition in or as always true etc etc... :)