From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Wed, 30 Sep 2020 22:37:28 +0000 Message-ID: References: <87d02318fl.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33052"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43725@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 00:38:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNkjg-0008Vw-Jq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 00:38:08 +0200 Original-Received: from localhost ([::1]:43892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNkjf-0004GW-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 18:38:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNkja-0004GB-Dp for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 18:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNkja-00047B-58 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 18:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNkja-0001Ze-25 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 18:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.16015054536015 (code B ref 43725); Wed, 30 Sep 2020 22:38:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 30 Sep 2020 22:37:33 +0000 Original-Received: from localhost ([127.0.0.1]:33349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNkj7-0001Yx-BN for submit@debbugs.gnu.org; Wed, 30 Sep 2020 18:37:33 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNkj5-0001Yi-IQ for 43725@debbugs.gnu.org; Wed, 30 Sep 2020 18:37:32 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 08UMbS4s004172; Wed, 30 Sep 2020 22:37:28 GMT In-Reply-To: <87d02318fl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 19:27:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189437 Archived-At: Lars Ingebrigtsen writes: > Andrea Corallo writes: > >> this is to handle code-review and process whose final goal is to have >> the feature/native-comp branch merged into master. > > Was the patch against the trunk supposed to be included here? Hi Lars, no it wasn't :) In the sense that I'm not sure how do we prefer to proceed with the review and I'm open for inputs on that. I didn't know if every time I update the branch is worth posting here a 10K+ LOC patch, so I waited. Also assuming the review will take some time to go through I'm not really sure how this is practical. OTOH as the branch is already in emacs.git should be trivial for reviewers at any point in time to produce the diff and quote the parts they like to discuss. Slightly different but related: I wanted to mention that I think would be really good if possible to retain the current history. That is going for a merge instead of applying a single patch. I believe this would be of great help for me to maintain the code in the future. Please let me know how you prefer we proceed. Thanks! Andrea