From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Thu, 18 Feb 2021 21:00:29 +0000 Message-ID: References: <865z3866my.fsf@gmail.com> <865z38a9vo.fsf@gmail.com> <86eehujcip.fsf@gmail.com> <86blch14qt.fsf@gmail.com> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46256@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 22:01:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCqQd-0009RY-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 22:01:39 +0100 Original-Received: from localhost ([::1]:52604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCqQc-00020c-3O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 16:01:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCqQ2-0001zL-HS for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCqQ2-0006Br-8B for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCqQ2-0006Jl-65 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161368203222563 (code B ref 46256); Thu, 18 Feb 2021 21:01:02 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 18 Feb 2021 21:00:32 +0000 Original-Received: from localhost ([127.0.0.1]:48236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCqPY-0005ra-BH for submit@debbugs.gnu.org; Thu, 18 Feb 2021 16:00:32 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:50737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCqPW-0005on-9u for 46256@debbugs.gnu.org; Thu, 18 Feb 2021 16:00:30 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11IL0TgT016730 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 18 Feb 2021 21:00:29 GMT In-Reply-To: <86blch14qt.fsf@gmail.com> (Andy Moreton's message of "Thu, 18 Feb 2021 20:48:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200290 Archived-At: Andy Moreton writes: > On Wed 17 Feb 2021, Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > >> Andy Moreton writes: >> >>> On Thu 04 Feb 2021, Andy Moreton wrote: >>> >>>> On Thu 04 Feb 2021, Andy Moreton wrote: >>>> >>>>> On Wed 03 Feb 2021, akrl--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >>>>>> >>>>>> Hi Andy, >>>>>> >>>>>> could you share the values of PATH_DUMPLOADSEARCH and >>>>>> PATH_REL_LOADSEARCH from your epaths.h ? >>>>>> >>>>>> Thanks >>>>>> >>>>>> Andrea >>>>> >>>>> Native branch checkout is in: "c:/emacs/git/emacs/native/" >>>>> >>>>> "c:/emacs/git/emacs/native/build/mingw64-x86_64-O2/src/epaths.h" contains: >>>>> >>>>> #define PATH_DUMPLOADSEARCH "C:/emacs/git/emacs/native/lisp" >>>>> #define PATH_REL_LOADSEARCH "28.0.50/lisp" >>>> >>>> I've bootstrapped again after the recent hash shortening to ensure my build >>>> is up to date, from commit 1f626e9662d8120acd5a937f847123cc2b8c6e31. The >>>> paths above are unchanged. >>>> >>>> Running this from the build dir, I see messages like: >>>> >>>> error in process sentinel: Native elisp load failed: "file does not exists", >>>> "c:/home/ajm/.emacs.d/eln-cache/28.0.50-e2ae3598/hl-line-e67628ec-664ef650.eln" >>>> >>>> This suggests that the AOT .eln files are not being found. It should find: >>>> >>>> c:/emacs/git/emacs/native/build/mingw64-x86_64-O2/native-lisp/28.0.50-e2ae3598/hl-line-8fa29c14-664ef650.eln >>>> >>>> The middle hash (e67628ec vs. 8fa29c14) is not the same - any idea why ? >>> >>> After looking at what `comp-el-to-eln-filename' does, I observe that: >>> >>> (substring (md5 "c:/emacs/git/emacs/native/lisp/hl-line.el") 0 8) >>> "e67628ec" >>> >>> (substring (md5 "//hl-line.el") 0 8) >>> "8fa29c14" >>> >>> That matches the two middle hashes seen above. >>> >>> It looks like `comp-el-to-eln-filename` fails to match the filename >>> prefix against PATH_DUMPLOADSEARCH. It is using case-sensitive matching, >>> but on Windows filesystems are case-insensitive. >> >> Hi Andy, >> >> The Windows filesystem is case-insensitive but the case is preserved >> correct? If so it should work no? > > Yes, Windows filesystems are case-preserving and do case-insensitive > lookup. The fact the code complains about the file not existing, and the > hashes matching as described earlier shows it is clearnly not working. I > have conjectured why, but the reason may well be something else. > >> Last queston: do reverse slashes '\' appear somewhere in those >> filenames? This was issue I tried to fix with the blind patch I've >> sent. > > As Eli pointed out, that is not the problem: forward slashes are ok. I understand they are handled, but here as we do a substitution we must substitute what's coming in. As you have the possibility to debug this piece of code on Windows please have a look at this (or try my blind patch if you haven't). Thanks Andrea