From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43190: feature/native-comp; failure to compile json-mode leaves Emacs broken Date: Fri, 18 Sep 2020 19:23:52 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 43190@debbugs.gnu.org To: Tom Gillespie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 21:52:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJMR9-00068v-2T for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 21:52:51 +0200 Original-Received: from localhost ([::1]:46486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMR8-0003Jm-1U for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 15:52:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJM0E-0000YW-3Z for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJM0D-00049F-Mt for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJM0D-0004T7-Jj for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43190 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Emacs Bug Report Original-Received: via spool by submit@debbugs.gnu.org id=B.160045704317107 (code B ref -1); Fri, 18 Sep 2020 19:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Sep 2020 19:24:03 +0000 Original-Received: from localhost ([127.0.0.1]:44441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLzH-0004Rr-B5 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 15:24:03 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLzF-0004RW-6a for submit@debbugs.gnu.org; Fri, 18 Sep 2020 15:24:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJLzE-0007Xf-UY for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:24:00 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:59492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJLzB-00042W-9n for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 15:24:00 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 08IJNqKl001250; Fri, 18 Sep 2020 19:23:52 GMT In-Reply-To: (Tom Gillespie's message of "Thu, 17 Sep 2020 13:49:28 -0400") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 15:09:10 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188347 Archived-At: Hi Tom, Tom Gillespie writes: > Hi Andrea, > Having poked about a bit more I agree. I don't think it has > anything to do with the native compilation directly. I suspect that it > has to do with how or exactly when the native compiled code is swapped > in. When byte compiling on the command line I get an error at the same > place that I get one when native compiling stating that json-snatcher > could not be required. As I mentioned what you have seen is 99% due to the fact that the compiled package is missing to require some feature explicitly. For some reason this feature in a interactive session in loaded and the byte-compiler is able to compile without complaining of this missing definition. The native compiler is picky as the byte compiler invoked in the command line (actually because the byte-compiler is its front-end). If for example the native compiler compiles a file using a macro but this is not defined it will assume this is a function. As a result the produced code is wrong and once loaded will not behave correctly. If a require is missing the code is not correct and we cannot garantee to compile such a code correctly, as the package has been fixed and there's no evidence of a native compiler bug I'd be for closing this bug :) Andrea