From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43532: [feature/native-comp] *.eln file name hashing algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained Emacs.app builds for macOS Date: Tue, 22 Sep 2020 07:58:59 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 43532@debbugs.gnu.org To: Jim Myhrberg Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 10:00:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKdE5-0007OL-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 10:00:37 +0200 Original-Received: from localhost ([::1]:33252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKdE3-0006dU-W5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 04:00:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKdDX-0006ct-7H for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 04:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKdDW-0003B7-QT for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 04:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKdDW-0001mA-Ov for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 04:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43532 X-GNU-PR-Package: emacs Original-Received: via spool by 43532-submit@debbugs.gnu.org id=B43532.16007615426725 (code B ref 43532); Tue, 22 Sep 2020 08:00:02 +0000 Original-Received: (at 43532) by debbugs.gnu.org; 22 Sep 2020 07:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:57066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKdCY-0001kO-H7 for submit@debbugs.gnu.org; Tue, 22 Sep 2020 03:59:02 -0400 Original-Received: from mab.sdf.org ([205.166.94.33]:38808 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKdCW-0001jz-Ou for 43532@debbugs.gnu.org; Tue, 22 Sep 2020 03:59:01 -0400 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kKdCV-0000eX-6f; Tue, 22 Sep 2020 07:58:59 +0000 In-Reply-To: (Jim Myhrberg's message of "Mon, 21 Sep 2020 22:17:00 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188665 Archived-At: Jim Myhrberg writes: > Hi Andrea, > > I've just tested that branch, and I'm afraid it doesn't work. It > starts native compiling cconv.el and others like before. Looking at > the changes, I believe it's looking for "Emacs.app" within > PATH_DUMPLOADSEARCH, which didn't actually contain that in my build > directory, it was PATH_LOADSEARCH that did. So currently that branch > doesn't find the bundled *.eln files even when the app is named > "Emacs.app". > > And annoyingly we also need to support it if the user renames the app > to something else, like "Emacs 28.app", or "Emacs Native.app", or even > something crazy like "fooBar! LaLa.app". > > My knowledge of C is mostly non-existent, but in an effort to reduce > the feedback loop and not take up too much of your time, I'll try some > guess-based tweaks and see if I have any success :) > > Thanks again :) Hi Jim, apologies to a quick look I've inverted PATH_LOADSEARCH and PATH_DUMPLOADSEARCH in the code :/ I've also addressed the *.app suggestion (yesterday I've missed your mail). Lets see if I got it right now. Thanks Andrea