From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Tue, 09 Mar 2021 17:10:48 +0000 Message-ID: References: <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> <83tupms4mp.fsf@gnu.org> <838s6wqxyg.fsf@gnu.org> <831rcoqo70.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11639"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 20:16:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJhqF-0002ti-3e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 20:16:27 +0100 Original-Received: from localhost ([::1]:49796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJhqE-00038J-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 14:16:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJfss-0002je-Gk for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJfss-0001cU-5p for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJfss-00049e-0b for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161530985115953 (code B ref 46256); Tue, 09 Mar 2021 17:11:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 9 Mar 2021 17:10:51 +0000 Original-Received: from localhost ([127.0.0.1]:47841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfsh-00049F-9a for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:10:51 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:62406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJfsf-000496-Ms for 46256@debbugs.gnu.org; Tue, 09 Mar 2021 12:10:50 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 129HAmcC024847 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Mar 2021 17:10:49 GMT In-Reply-To: <831rcoqo70.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Mar 2021 18:36:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201927 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: pipcet@gmail.com, 46256@debbugs.gnu.org, andrewjmoreton@gmail.com >> Date: Tue, 09 Mar 2021 13:58:31 +0000 >> >> > I think it _is_ the case, but the problem might be that the refcount >> > is not zero, and therefore the shared library is not actually unloaded >> > and unmapped. (I say "might be" because I still don't see the >> > scenario where this could happen, and I'm not sure if it does happen >> > the solution should be as suggested -- it could be that it's better to >> > not load the .eln the second time, i.e. make 'load' behave like >> > 'require'). >> >> That was my understanding (as I don't see why dlclose should fail) but >> reading the man page: >> >> "On success, dlclose() returns 0; on error, it returns a nonzero value." >> >> So my understanding now is that it can fail. Am I wrong? > > I don't know. Posix says no errors are defined for dlclose, so maybe > look at the glibc sources to see what happens on GNU/Linux? To a quick look into GLIBC AFAIU dlclose can return non zero values. Also looking at [1] it says: "If handle does not refer to an open symbol table handle or if the symbol table handle could not be closed, dlclose() shall return a non-zero value." So yeah, don't know if this is a real case (never seen it in practice) but I think is good to be robust against in principal. Thanks Andrea [1]