* bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
@ 2020-06-22 20:52 Doug Davis
2020-06-22 22:41 ` Andrea Corallo
0 siblings, 1 reply; 4+ messages in thread
From: Doug Davis @ 2020-06-22 20:52 UTC (permalink / raw)
To: 42010
When running `gnus' with a native compiled Emacs build a message is
reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
is called. I'm not sure what check is possible to see if a function is
natively compiled, but perhaps it should be added to this logic in
gnus.el:
(unless (byte-code-function-p (symbol-function 'gnus))
(message "You should byte-compile Gnus")
(sit-for 2))
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
2020-06-22 20:52 bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el Doug Davis
@ 2020-06-22 22:41 ` Andrea Corallo
2020-06-23 6:44 ` Arthur Miller
0 siblings, 1 reply; 4+ messages in thread
From: Andrea Corallo @ 2020-06-22 22:41 UTC (permalink / raw)
To: Doug Davis; +Cc: 42010
Doug Davis <ddavis@ddavis.io> writes:
> When running `gnus' with a native compiled Emacs build a message is
> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
> is called. I'm not sure what check is possible to see if a function is
> natively compiled, but perhaps it should be added to this logic in
> gnus.el:
>
> (unless (byte-code-function-p (symbol-function 'gnus))
> (message "You should byte-compile Gnus")
> (sit-for 2))
I'll admint that added to my undenaiable laziness I probably skiped this
for so long cause was giving me a tiny satisfaction :)
Should be fixed by:
801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
compilation.
Thanks for the feedback
Andrea
--
akrl@sdf.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
2020-06-22 22:41 ` Andrea Corallo
@ 2020-06-23 6:44 ` Arthur Miller
2020-06-23 7:48 ` Andrea Corallo
0 siblings, 1 reply; 4+ messages in thread
From: Arthur Miller @ 2020-06-23 6:44 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 42010, Doug Davis
Andrea Corallo <akrl@sdf.org> writes:
> Doug Davis <ddavis@ddavis.io> writes:
>
>> When running `gnus' with a native compiled Emacs build a message is
>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>> is called. I'm not sure what check is possible to see if a function is
>> natively compiled, but perhaps it should be added to this logic in
>> gnus.el:
>>
>> (unless (byte-code-function-p (symbol-function 'gnus))
>> (message "You should byte-compile Gnus")
>> (sit-for 2))
>
> I'll admint that added to my undenaiable laziness I probably skiped this
> for so long cause was giving me a tiny satisfaction :)
>
> Should be fixed by:
>
> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
> compilation.
>
> Thanks for the feedback
>
> Andrea
Just rebuild my Emacs and can confirm it if fixed.
Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
Awesome, thanks Andrea!
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
2020-06-23 6:44 ` Arthur Miller
@ 2020-06-23 7:48 ` Andrea Corallo
0 siblings, 0 replies; 4+ messages in thread
From: Andrea Corallo @ 2020-06-23 7:48 UTC (permalink / raw)
To: Arthur Miller; +Cc: 42010-done, Doug Davis
Arthur Miller <arthur.miller@live.com> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Doug Davis <ddavis@ddavis.io> writes:
>>
>>> When running `gnus' with a native compiled Emacs build a message is
>>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>>> is called. I'm not sure what check is possible to see if a function is
>>> natively compiled, but perhaps it should be added to this logic in
>>> gnus.el:
>>>
>>> (unless (byte-code-function-p (symbol-function 'gnus))
>>> (message "You should byte-compile Gnus")
>>> (sit-for 2))
>>
>> I'll admint that added to my undenaiable laziness I probably skiped this
>> for so long cause was giving me a tiny satisfaction :)
>>
>> Should be fixed by:
>>
>> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
>> compilation.
>>
>> Thanks for the feedback
>>
>> Andrea
> Just rebuild my Emacs and can confirm it if fixed.
>
> Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
>
> Awesome, thanks Andrea!
Great, thank you for the testing :)
closing
Andrea
--
akrl@sdf.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-23 7:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-22 20:52 bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el Doug Davis
2020-06-22 22:41 ` Andrea Corallo
2020-06-23 6:44 ` Arthur Miller
2020-06-23 7:48 ` Andrea Corallo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).