From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 02 Oct 2020 19:39:29 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 43725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 02 21:40:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOQuZ-0004rr-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Oct 2020 21:40:11 +0200 Original-Received: from localhost ([::1]:58938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOQuY-00084f-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Oct 2020 15:40:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOQuQ-00084M-E1 for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2020 15:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOQuQ-0000ar-3v for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2020 15:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOQuQ-000488-1i for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2020 15:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Oct 2020 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 43725@debbugs.gnu.org Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.160166757515822 (code B ref 43725); Fri, 02 Oct 2020 19:40:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 2 Oct 2020 19:39:35 +0000 Original-Received: from localhost ([127.0.0.1]:42610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOQtz-000478-3D for submit@debbugs.gnu.org; Fri, 02 Oct 2020 15:39:35 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:57209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOQtv-00046w-B6 for 43725@debbugs.gnu.org; Fri, 02 Oct 2020 15:39:34 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 092JdTOv006207; Fri, 2 Oct 2020 19:39:29 GMT In-Reply-To: (Andrea Corallo via's message of "Wed, 30 Sep 2020 15:44:14 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189674 Archived-At: Hi all, FYI today I did some work to put the testsuite in shape also for the native build (vanilla pass clean already). The main challenge is related to the fact that the testsuite does large use of primitive redefinition (tipically through `cl-letf'). As redefining primitives does not take effect in optimized code I defined a macro (`advice-flet') with similar use but to advice instead and put it in place in a numer of tests. You'll see this work in d07d7ab1a0 825e85b393. I hope this approach is accettable (thought was good to ask for a feedback), otherwise we can revert and find another solution. ATM the testsuite for the native build runs still not clean, I'll finish with cleaning it up. Andrea