From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45443: 28.0.50; Can't find definition of compilation--message->loc Date: Sun, 27 Dec 2020 19:40:47 +0000 Message-ID: References: > <83a6u0n8y7.fsf@gnu.org>> <83lfdjkuzd.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38992"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rms@gnu.org, mardani29@yahoo.es To: 45443@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 27 20:41:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktbv5-000A3e-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 20:41:35 +0100 Original-Received: from localhost ([::1]:47528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktbv4-00013t-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 14:41:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktbuY-00013D-HC for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50243) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktbuY-0003rD-9L for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktbuY-0001kb-7f for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2020 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed X-Debbugs-Original-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Daniel =?UTF-8?Q?Mart=C3=ADn?= , rms@gnu.org, 45443@debbugs.gnu.org Original-Received: via spool by 45443-submit@debbugs.gnu.org id=B45443.16090980506684 (code B ref 45443); Sun, 27 Dec 2020 19:41:02 +0000 Original-Received: (at 45443) by debbugs.gnu.org; 27 Dec 2020 19:40:50 +0000 Original-Received: from localhost ([127.0.0.1]:33552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbuL-0001jk-St for submit@debbugs.gnu.org; Sun, 27 Dec 2020 14:40:50 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:59622 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbuK-0001jb-KU for 45443@debbugs.gnu.org; Sun, 27 Dec 2020 14:40:49 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1ktbuJ-0001V0-5d; Sun, 27 Dec 2020 19:40:47 +0000 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Sun, 27 Dec 2020 20:28:57 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196820 Archived-At: Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> >>> Why do we need to expand macros? isn't it enough to find the defstruct >>> itself, by looking for a partial match? >> >> I haven't look at the patch, but I think the approach of macro expanding >> is more general as should be able to track any function definition that >> is synthesized by any macro. >> > > Yes, my patch tried a more general approach, which would not only find > function definitions, but also defvars like the hooks that are > synthesized by define-major-mode, for example. > > There's some opportunities to do less work, though. For example, I > think it does not make sense to expand defuns because those were handled > in a previous step. I think that'd reduce the search space > significantly. > > Another possible approach for this problem is to search textually for > just the things that we're typically interested in (like, cl-defstruct > or define-derived-mode), and expand only those to see if they synthesize > the symbol we are looking for. It will be a less general solution, but > it will be faster. We may add more cases in the future, if needed. > > Thoughts? I personally like the generic approach. Also considered should be running only when the regexp based one is failing and therefore with no performance hit in most cases but only fixing the broken ones. Andrea