From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46824: 28.0.50; nativecomp crash with cl-block/cl-defun Date: Mon, 01 Mar 2021 17:04:02 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38203"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46824@debbugs.gnu.org, Aaron Jensen To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 18:05:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGlz6-0009km-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 18:05:28 +0100 Original-Received: from localhost ([::1]:41842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGlz5-0000UI-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 12:05:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGlyh-0000T1-Lw for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGlyg-0003ff-En for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGlyg-0007Oi-AD for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 12:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46824 X-GNU-PR-Package: emacs Original-Received: via spool by 46824-submit@debbugs.gnu.org id=B46824.161461824728370 (code B ref 46824); Mon, 01 Mar 2021 17:05:02 +0000 Original-Received: (at 46824) by debbugs.gnu.org; 1 Mar 2021 17:04:07 +0000 Original-Received: from localhost ([127.0.0.1]:50661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGlxm-0007NW-Mp for submit@debbugs.gnu.org; Mon, 01 Mar 2021 12:04:06 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:62748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGlxk-0007NA-Mw for 46824@debbugs.gnu.org; Mon, 01 Mar 2021 12:04:05 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 121H42DU004817 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 1 Mar 2021 17:04:02 GMT In-Reply-To: (Pip Cet's message of "Mon, 1 Mar 2021 13:02:03 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201129 Archived-At: Pip Cet writes: > On Mon, Mar 1, 2021 at 9:02 AM Andrea Corallo wrote: >> Pip Cet writes: >> > On Sun, Feb 28, 2021 at 6:13 AM Pip Cet wrote: >> >> Andrea, is it possible to modify the code so _setjmp is called >> >> directly rather than through a function pointer? >> > >> > This patch, which I hasten to add is not for inclusion and hasn't been >> > tested against the test suite, might fix the problem (on non-Windows >> > systems. I'm afraid this problem is something that Windows actually >> > got right and Unix got wrong...) It does here, experimentally. >> > >> > I'd appreciate it if someone could test further. >> >> I haven't looked into the patch but the approach sounds like a good idea >> to me. Can we have the version of the patch you'd like to have included? > > Here's the version I'd like to include. This should not cause any new > test suite failures, just the ones I've been seeing all along. Apart > from the ABI bump, it should not change anything on WINDOWSNT, which I > can't test. > > Pip Hi Pip, thanks for the patch. Please add to the patch the reported reproducer into test/src/comp-test-funcs.el exercising it from test/src/comp-tests.el, you can probably place it after the last reproducer that was added there (46670). Thanks Andrea