unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: bryan.m.obrien@gmail.com, Eli Zaretskii <eliz@gnu.org>,
	47558@debbugs.gnu.org
Subject: bug#47558: 28.0.50; dlopen 'image not found' gccemacs native-lisp macos
Date: Wed, 07 Apr 2021 07:53:50 +0000	[thread overview]
Message-ID: <xjfmtuah6nl.fsf@sdf.org> (raw)
In-Reply-To: <YGzTr0MZabvcE11R@breton.holly.idiocy.org> (Alan Third's message of "Tue, 6 Apr 2021 22:33:35 +0100")

Alan Third <alan@idiocy.org> writes:

> On Tue, Apr 06, 2021 at 09:22:57PM +0000, Andrea Corallo wrote:
>> Alan Third <alan@idiocy.org> writes:
>> 
>> > On Tue, Apr 06, 2021 at 07:26:16PM +0000, Andrea Corallo wrote:
>> >> 
>> >> Okay the log looks good AFAICT.
>> >> 
>> >> We are suggesting the eln to go in:
>> >> /Users/alan/src/emacs/native/nextstep/Emacs.app/Contents/MacOS/bin/
>> >> 
>> >> and the eln in:
>> >> /Users/alan/src/emacs/native/nextstep/Emacs.app/Contents/Resources/
>> >
>> > OK, I think I see what's going on. The binary is installed in
>> > Emacs.app/Contents/MacOS, but the bindir is
>> > Emacs.app/Contents/MacOS/bin, so we're going one level too far up when
>> > generating the eln path.
>> >
>> > "../../Resources/native-lisp/28.0.50-0f05d3d3/preloaded/misc-lang-7cb33d20-db3eb4ae.eln"
>> >
>> >> If this does not help I suggest we apply the attached and re-bootstrap
>> >> to see if the 'rel-filename-from-install-bin' we are constructing is
>> >> correct.
>> >
>> > I've attached the new bootstrap log in case I'm wrong and you can see
>> > something else.
>> 
>> I think your analysis is correct.
>> 
>> ATM we form BIN_DESTDIR as '$(DESTDIR)${bindir}/' (Makefile.in:419),
>> maybe we should use 'ns_appbindir' to form it?
>
> Yup, that seems to have solved it. I'm doing this:

Cool!

> modified   Makefile.in
> @@ -420,8 +420,13 @@ lib lib-src lisp nt:
>  dirstate = .git/logs/HEAD
>  VCSWITNESS = $(if $(wildcard $(srcdir)/$(dirstate)),$$(srcdir)/../$(dirstate))
>  src: Makefile
> +ifeq (${ns_self_contained},no)
>  	$(MAKE) -C $@ VCSWITNESS='$(VCSWITNESS)' BIN_DESTDIR='$(DESTDIR)${bindir}/' \
>  		 ELN_DESTDIR='$(ELN_DESTDIR)' all
> +else
> +	$(MAKE) -C $@ VCSWITNESS='$(VCSWITNESS)' BIN_DESTDIR='${ns_appbindir}/' \
> +		 ELN_DESTDIR='$(ELN_DESTDIR)' all
> +endif
>  
>  blessmail: Makefile src
>  	$(MAKE) -C lib-src maybe-blessmail
>
>
> which works, but I don't know much about makefiles so there may be a
> neater way to do it.

I think we could prepare BIN_DESTDIR near ELN_DESTDIR so we don't have
to duplicate the sub-make invocation in this target.  I pushed
ce15b23846 that does that.

Please feel free to install a patch with all the other necessary changes
to have it working on MacOS.

Thanks!

  Andrea





  parent reply	other threads:[~2021-04-07  7:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  1:36 bug#47558: 28.0.50; dlopen 'image not found' gccemacs native-lisp macos Bryan O'Brien
2021-04-02  5:46 ` Eli Zaretskii
2021-04-02 16:29   ` Alan Third
2021-04-02 18:39     ` Eli Zaretskii
2021-04-02 21:51       ` Alan Third
2021-04-03  6:32         ` Eli Zaretskii
2021-04-03 14:01           ` Alan Third
2021-04-03 14:17             ` Eli Zaretskii
2021-04-04  7:10               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 10:34                 ` Alan Third
2021-04-05 20:21                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-05 21:14                     ` Alan Third
2021-04-06  7:56                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 10:00                         ` Alan Third
2021-04-06 14:51                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 17:36                             ` Alan Third
2021-04-06 19:26                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 21:11                                 ` Alan Third
2021-04-06 21:22                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-06 21:33                                     ` Alan Third
2021-04-07  2:08                                       ` Bryan O'Brien
2021-04-07  7:53                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-04-07  8:18                                         ` Alan Third
2021-04-07  9:08                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-07  9:58                                             ` Alan Third
2021-04-07 10:31                                               ` Andreas Schwab
2021-04-07 10:35                                               ` Andreas Schwab
2021-04-07 10:48                                                 ` Alan Third
2021-04-07 11:50                                                   ` Eli Zaretskii
2021-04-07 12:15                                                     ` Eli Zaretskii
2021-04-07 12:31                                                     ` Alan Third
2021-04-07 11:45                                               ` Eli Zaretskii
2021-04-07 14:20                                                 ` Alan Third
2021-04-07 14:25                                                   ` Eli Zaretskii
2021-04-07 18:41                                           ` Bryan O'Brien
2021-04-07 18:45                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-07 16:46                                 ` Eli Zaretskii
2021-04-07 18:30                                   ` Bryan O'Brien
2021-04-07 18:43                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfmtuah6nl.fsf@sdf.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=47558@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=alan@idiocy.org \
    --cc=bryan.m.obrien@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).