From: Andrea Corallo <akrl@sdf.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 52220@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions
Date: Wed, 01 Dec 2021 21:16:01 +0000 [thread overview]
Message-ID: <xjfmtlkxbzi.fsf@ma.sdf.org> (raw)
In-Reply-To: <875ys8f4lw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 01 Dec 2021 21:32:43 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> shouldn't we declare structure predicates as pure functions?
>
> I think that's correct? The predicates take the struct as the argument,
> so they seem like pure functions to me. I've added Stefan to the CCs;
> perhaps there's some subtlety here I don't see.
Yes we have all conventional predicates as pure, the only difference is
that here the result of the predicate depends also on the global state.
IOW redefining a structure could change the result of a predicate, but
my guess is that we don't want to be robust against that (structs in
general AFAIK are not robust against run-time redefinition).
Andrea
prev parent reply other threads:[~2021-12-01 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 10:29 bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions Andrea Corallo
2021-12-01 20:32 ` Lars Ingebrigtsen
2021-12-01 21:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-01 21:23 ` Andrea Corallo
2021-12-01 21:16 ` Andrea Corallo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfmtlkxbzi.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=52220@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).