From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Improve handling of native compilation... Date: Sun, 24 May 2020 19:13:59 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="10103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41242@debbugs.gnu.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 24 21:15:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcw5W-0002Vz-ND for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 May 2020 21:15:10 +0200 Original-Received: from localhost ([::1]:43736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcw5V-00046U-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 May 2020 15:15:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcw5O-00046I-LZ for bug-gnu-emacs@gnu.org; Sun, 24 May 2020 15:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcw5O-0005md-CI for bug-gnu-emacs@gnu.org; Sun, 24 May 2020 15:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcw5O-0008Vk-6l for bug-gnu-emacs@gnu.org; Sun, 24 May 2020 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2020 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159034764332621 (code B ref 41242); Sun, 24 May 2020 19:15:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 24 May 2020 19:14:03 +0000 Original-Received: from localhost ([127.0.0.1]:38762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcw4Q-0008U5-Vz for submit@debbugs.gnu.org; Sun, 24 May 2020 15:14:03 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:65476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcw4O-0008TX-Mm for 41242@debbugs.gnu.org; Sun, 24 May 2020 15:14:01 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04OJDxdO022681 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 24 May 2020 19:13:59 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04OJDxpP030955; Sun, 24 May 2020 19:13:59 GMT In-Reply-To: ("Nicolas =?UTF-8?Q?B=C3=A9rtolo?="'s message of "Sun, 24 May 2020 14:58:15 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180922 Archived-At: Nicolas B=C3=A9rtolo writes: >> The problem is that GC is called (especially by default) *very* >> frequently, bounding GC performance to filesystem accesses is > really not >> a good idea IMO because we have no control over this last. >> >> You could not see a difference here because: >> >> - spaceemacs GC settings runs it way less often coming with a > bigger >> =C2=A0 gc-cons-threshold by default >> >> - GC euristincs being GC slow decides to give-up a little and > accept >> =C2=A0 running less often leading to more fragmentation >> >> - filesystem is blazingly fast >> >> - you haven't measured ;) > > Actually unloading a native compilation unit is such an unfrequent > operation > that all that finish_delayed_disposal_of_comp_units() does is compare > a pointer > to NULL. It will not slowdown the GC at all. > > Anyway, I could change this to run on an idle timer or just handle it > when Emacs > closes. Which do you prefer? What you say is correct, collecting a compilation unit is very infrequent now. But code could decide to native compile functions each time a performance critical operation has to be done, real world code does that already relying on the byte-compiler. I think to start with doing the clean-up when Emacs is closing is sufficient, we can always add the timer in case we feel the need. Thanks Andrea --=20 akrl@sdf.org