From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 18 Feb 2021 21:22:54 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83wnv67mei.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11643"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 22:23:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCqlX-0002vZ-Ex for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 22:23:15 +0100 Original-Received: from localhost ([::1]:37284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCqlW-0000TA-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 16:23:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCqlK-0000SC-Ja for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCqlJ-00008S-Qd for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCqlJ-00081l-MN for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 21:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161368337730835 (code B ref 43725); Thu, 18 Feb 2021 21:23:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 18 Feb 2021 21:22:57 +0000 Original-Received: from localhost ([127.0.0.1]:48271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCqlF-00081H-Kg for submit@debbugs.gnu.org; Thu, 18 Feb 2021 16:22:57 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:63424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCqlE-000819-Fc for 43725@debbugs.gnu.org; Thu, 18 Feb 2021 16:22:57 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11ILMsU5015727 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 18 Feb 2021 21:22:55 GMT In-Reply-To: <83wnv67mei.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Feb 2021 17:18:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200291 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org >> Date: Tue, 16 Feb 2021 21:13:07 +0000 >> >> Addressing some easy part of the review to close the day. > > Thanks. > >> > Likewise, this is unsafe because a fixnum can be larger than INT_MAX: >> > >> > + if (!FIXNUMP (idx)) >> > + xsignal1 (Qnative_ice, >> > + build_string ("inconsistent data relocation container")); >> > + reloc.idx = gcc_jit_context_new_rvalue_from_int (comp.ctxt, >> > + comp.ptrdiff_type, >> > + XFIXNUM (idx)); <<<<<<<< >> > >> > (There are several more calls with the same problem.) >> >> Should we never trust in C a value coming from a Lisp_Object even if is >> supposed to be constructed on purpose? > > We can trust that if we indeed make the value explicitly, but if > there's at least a tiny chance to get a value that's too large, at > least an assertion would be a good idea. That's sensible. 185121da69 and b1bab6e073 are introducing assertions for the highlighted cases and the other one I've spotted. Thanks Andrea