From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50666: 28.0.50; Fix native compilation on Cygwin Date: Thu, 23 Sep 2021 19:11:05 +0000 Message-ID: References: <9f20194e-b1ba-9417-4f18-caa1d80b5568@cornell.edu> <01a89ba6-2786-df04-0181-069b50a70331@cornell.edu> <835yux5dn1.fsf@gnu.org> <87bl4pf3s1.fsf@Otto.invalid> <83tuih3uvr.fsf@gnu.org> <877dfcg5tu.fsf@Otto.invalid> <83pmt44vn1.fsf@gnu.org> <83mto84r9l.fsf@gnu.org> <83fsu04mai.fsf@gnu.org> <1a5e01a2-2247-2f68-82f6-2075577e02b6@cornell.edu> <837dfc4hi1.fsf@gnu.org> <4ae8067f-55b2-d243-66f3-f76493095a39@cornell.edu> <83o88jvity.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stromeko@nexgo.de, 50666@debbugs.gnu.org, Ken Brown To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 23 21:12:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTU8l-00009T-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 21:12:15 +0200 Original-Received: from localhost ([::1]:46500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTU8k-0000hi-3O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Sep 2021 15:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTU8Y-0000hU-OZ for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 15:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTU8Y-0008AT-Hj for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTU8Y-0002mW-9m for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Sep 2021 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50666-submit@debbugs.gnu.org id=B50666.163242427710629 (code B ref 50666); Thu, 23 Sep 2021 19:12:02 +0000 Original-Received: (at 50666) by debbugs.gnu.org; 23 Sep 2021 19:11:17 +0000 Original-Received: from localhost ([127.0.0.1]:55899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTU7o-0002lM-VH for submit@debbugs.gnu.org; Thu, 23 Sep 2021 15:11:17 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:58267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTU7m-0002lA-K3 for 50666@debbugs.gnu.org; Thu, 23 Sep 2021 15:11:15 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 18NJB5kU025282 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 23 Sep 2021 19:11:07 GMT In-Reply-To: <83o88jvity.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Sep 2021 10:42:33 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215221 Archived-At: Eli Zaretskii writes: >> Cc: Stromeko@nexgo.de, 50666@debbugs.gnu.org >> From: Ken Brown >> Date: Wed, 22 Sep 2021 17:35:28 -0400 >> >> We've made a good start on the Cygwin side, but I have a question about how to >> integrate it into Emacs. > > I added Andrea to this discussion, as he knows more than anyone else > about the Emacs side of this stuff. > >> Let's say we have a script that I'll call "rebase" for the purpose of this >> discussion, which rebases all the eln files in ~/.emacs.d/eln-cache. The user >> would then start Emacs via a script that first calls rebase and then starts >> Emacs. > > Is it really necessary to rebase the *.eln files before each startup? > Isn't it enough to rebase each of the .eln files just once, when it is > produced? If indeed this is needed every time, can you explain why? > >> Within Emacs, I would then want to do something like >> >> (if (eq system-type 'cygwin) >> (call-process "rebase" nil >> '(:file "") >> nil "" ...)) >> >> after every compilation but before the compiled file is loaded. >> >> I'm not familiar enough with native compilation to know where this should go. > > The non-preloaded *.eln files are all loaded by native-elisp-load, so > I guess the rebase should be launched from there? The preloaded *.eln > files are loaded in pdumper.c:dump_do_dump_relocation, but do we need > to support non-rebased preloaded *.eln files? Yes I think too `native-elisp-load' and `dump_do_dump_relocation' are the two places we'd want to trigger the rebase (not sure if in `dump_do_dump_relocation' we are already able to spawn subprocesses tho). That said I'm wondering what is going to happen if an Emacs is running and a second sessions starts rebasing some eln. Andrea