From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time Date: Sat, 29 May 2021 07:02:45 +0000 Message-ID: References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> <83tumo8f4f.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48578@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 29 09:03:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmt0L-000223-8g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 09:03:29 +0200 Original-Received: from localhost ([::1]:59266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmt0K-0004h0-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 03:03:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmszu-0004eN-Be for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 03:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmszu-00054c-3e for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 03:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmszu-0004rd-0P for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 03:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2021 07:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48578 X-GNU-PR-Package: emacs Original-Received: via spool by 48578-submit@debbugs.gnu.org id=B48578.162227176818678 (code B ref 48578); Sat, 29 May 2021 07:03:01 +0000 Original-Received: (at 48578) by debbugs.gnu.org; 29 May 2021 07:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:55889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmszg-0004rC-Jx for submit@debbugs.gnu.org; Sat, 29 May 2021 03:02:48 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:59081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmszf-0004r4-4Z for 48578@debbugs.gnu.org; Sat, 29 May 2021 03:02:47 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14T72jJO008020 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 29 May 2021 07:02:46 GMT In-Reply-To: <83tumo8f4f.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 16:45:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207510 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: 48578@debbugs.gnu.org >> Date: Thu, 27 May 2021 11:57:22 +0000 >> >> > . why do you use Fexpand_file_name _after_ realpath? shouldn't we >> > call it before realpath instead? >> >> Right that's correct. >> >> > . we need to encode the file name before passing it to realpath, and >> > decode the result, right? >> >> Correct >> >> > . realpath could potentially return NULL, and we should check for >> > that, and return the result of Fexpand_file_name if it does >> >> Of course >> >> > . we don't need to support remote files here via file-handlers, >> > right? >> >> Correct, so far we do not support it. >> >> > If you agree with the above, I will prepare a proper patch and install >> > it, including the necessary changes for WINDOWSNT. >> >> Agreed, thanks. > > Thanks, I installed a fix along these lines, please review and > comment. Hi Eli, it looks good to me. Thanks for fixing this. Andrea