From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41194: 28.0.50; [feature/native-comp] fibn benchmark exhausts memory Date: Sun, 14 Jun 2020 16:19:06 +0000 Message-ID: References: <87y2pyi4gq.fsf@gmail.com> <874krj1hjh.fsf@gmail.com> <877dw9k73y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41194@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 14 18:20:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkVMk-0008PR-9k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jun 2020 18:20:14 +0200 Original-Received: from localhost ([::1]:37976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkVMj-00030F-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jun 2020 12:20:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkVMY-0002z5-11 for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 12:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkVMX-0004U1-Ne for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 12:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkVMX-0002HG-JQ for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 12:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jun 2020 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41194 X-GNU-PR-Package: emacs Original-Received: via spool by 41194-submit@debbugs.gnu.org id=B41194.15921515538661 (code B ref 41194); Sun, 14 Jun 2020 16:20:01 +0000 Original-Received: (at 41194) by debbugs.gnu.org; 14 Jun 2020 16:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:44357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkVLl-0002Fd-Cj for submit@debbugs.gnu.org; Sun, 14 Jun 2020 12:19:13 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:53822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkVLh-0002FR-7G for 41194@debbugs.gnu.org; Sun, 14 Jun 2020 12:19:12 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 05EGJ6tJ029648 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 14 Jun 2020 16:19:07 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 05EGJ6GG028447; Sun, 14 Jun 2020 16:19:06 GMT In-Reply-To: <877dw9k73y.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Sun, 14 Jun 2020 17:19:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181949 Archived-At: K=C3=A9vin Le Gouguec writes: > Andrea Corallo writes: > >> 5a55a845a7 * Implement 'maybe_gc_or_quit' to allow correct GC in compile= d Lisp >> 34ed9d2498 * Introduce latches >> >> are fixing here this issue, now running fibn at speed 2 the memory >> consuptions stays constant. > > Alright, feedback time! > > Commits: > - master: 82a632edc8b80bf16d9b9f205474bf9724b084c0 > - feature/native-comp: 5a55a845a7c426e82e8a6a6d02bc4a39992871e3 > > > The Good News > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > - I can compile the branch without adding files to the default > blacklist, > > - compilation (-j1) now only takes less than 6 hours instead of 3 days > (compared with 1.5 hour on master), > > - at no point during compilation did the system swap; in fact, I could > probably have risked a -j2 build, > > - elisp-benchmarks doesn't show any obvious performance regression > (=E2=80=A6 though see Bad News). > > For details on memory usage during compilation, see attached memory > profile (to compare with bug#41077#28). Hi K=C3=A9vin, this is very good new thanks! If I read correctly we are always under about 600MB as memory consumption is this correct? > > Few files take more than 3 minutes to compile now: > > ELC+ELN emacs-lisp/comp.el 0:09:49 > ELC+ELN org/org.el 0:03:39 > ELC+ELN ../lisp/window.el 0:03:16 > ELC+ELN emacs-lisp/bytecomp.el 0:03:16 > > For details on performance, see attached tables for master and > feature/native-comp, respectively (to compare with bug#41077#40). > > > > > The Bad News > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > - fibn still exhausts memory, > - now pidigits does too. > > > > > I've only tried the default comp-speed (2) so far. I've attached the > results of M-x disassemble on the functions in fibn.el and pidigits.el. I suspect we are still looking at a speed 3 run. How comp-speed was set for the test? I ask that because for now speed 3 is written into the stone within elisp-benchmarks.el, yeah... :/ and so has to be manually changed there. Thanks! Andrea --=20 akrl@sdf.org