From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el Date: Tue, 23 Jun 2020 07:48:25 +0000 Message-ID: References: <87zh8u258r.fsf@ddavis.io> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126015"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 42010-done@debbugs.gnu.org, Doug Davis To: Arthur Miller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 09:49:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jndg7-000WfN-4L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 09:49:11 +0200 Original-Received: from localhost ([::1]:50982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jndg6-00034i-30 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 03:49:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jndfz-00032x-3e for bug-gnu-emacs@gnu.org; Tue, 23 Jun 2020 03:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jndfy-0000sj-QM for bug-gnu-emacs@gnu.org; Tue, 23 Jun 2020 03:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jndfy-0001G6-Hd; Tue, 23 Jun 2020 03:49:02 -0400 Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 23 Jun 2020 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42010 X-GNU-PR-Package: emacs,gnus Mail-Followup-To: 42010@debbugs.gnu.org, akrl@sdf.org, ddavis@ddavis.io Original-Received: via spool by 42010-done@debbugs.gnu.org id=D42010.15928985194799 (code D ref 42010); Tue, 23 Jun 2020 07:49:02 +0000 Original-Received: (at 42010-done) by debbugs.gnu.org; 23 Jun 2020 07:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:35389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jndfb-0001FL-6X for submit@debbugs.gnu.org; Tue, 23 Jun 2020 03:48:39 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:52814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jndfY-0001F6-4Z for 42010-done@debbugs.gnu.org; Tue, 23 Jun 2020 03:48:38 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 05N7mPOE013308 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 23 Jun 2020 07:48:26 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 05N7mPHu018599; Tue, 23 Jun 2020 07:48:25 GMT In-Reply-To: (Arthur Miller's message of "Tue, 23 Jun 2020 08:44:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182308 Archived-At: Arthur Miller writes: > Andrea Corallo writes: > >> Doug Davis writes: >> >>> When running `gnus' with a native compiled Emacs build a message is >>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for' >>> is called. I'm not sure what check is possible to see if a function is >>> natively compiled, but perhaps it should be added to this logic in >>> gnus.el: >>> >>> (unless (byte-code-function-p (symbol-function 'gnus)) >>> (message "You should byte-compile Gnus") >>> (sit-for 2)) >> >> I'll admint that added to my undenaiable laziness I probably skiped this >> for so long cause was giving me a tiny satisfaction :) >> >> Should be fixed by: >> >> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native >> compilation. >> >> Thanks for the feedback >> >> Andrea > Just rebuild my Emacs and can confirm it if fixed. > > Build time seems to be even faster (on my 67k i7 cpu with -j8 switch). > > Awesome, thanks Andrea! Great, thank you for the testing :) closing Andrea -- akrl@sdf.org