From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 01 Oct 2020 07:51:16 +0000 Message-ID: References: <87d02318fl.fsf@gnus.org> <878scqwwyw.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43725@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 09:52:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNtNt-000ABz-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 09:52:13 +0200 Original-Received: from localhost ([::1]:40172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNtNp-0005hc-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 03:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNtNi-0005hU-1Y for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 03:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNtNh-0006U6-OM for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 03:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNtNh-00071h-Mg for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 03:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.160153868126964 (code B ref 43725); Thu, 01 Oct 2020 07:52:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 1 Oct 2020 07:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:33924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNtN3-00070q-Ai for submit@debbugs.gnu.org; Thu, 01 Oct 2020 03:51:21 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:55922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNtMz-00070e-PC for 43725@debbugs.gnu.org; Thu, 01 Oct 2020 03:51:20 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0917pGiT006149; Thu, 1 Oct 2020 07:51:16 GMT In-Reply-To: <878scqwwyw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Oct 2020 03:34:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189473 Archived-At: Lars Ingebrigtsen writes: > Andrea Corallo writes: > >>> Was the patch against the trunk supposed to be included here? >> >> Hi Lars, no it wasn't :) >> >> In the sense that I'm not sure how do we prefer to proceed with the >> review and I'm open for inputs on that. > > Right. :-) > >> I didn't know if every time I update the branch is worth posting here a >> 10K+ LOC patch, so I waited. Also assuming the review will take some >> time to go through I'm not really sure how this is practical. >> >> OTOH as the branch is already in emacs.git should be trivial for >> reviewers at any point in time to produce the diff and quote the parts >> they like to discuss. > > Sure, that's fine. That would be > > git diff origin/feature/native-comp..origin/master > > ? I think something like this would add into the diff all new commits that where pushed to master. One option is to do the same but against the last commit from master included into the branch (it's easy to identify as just under the last merge). ATM would be: git diff 6c0f1c26d2...origin/feature/native-comp Other option is to just merge master into native-comp and do the diff against master. Not a git wizard so there could be even simpler ways to do that :) >> Slightly different but related: I wanted to mention that I think would >> be really good if possible to retain the current history. That is going >> for a merge instead of applying a single patch. I believe this would be >> of great help for me to maintain the code in the future. > > Sure, sounds good. Great Thanks Andrea