From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Tue, 06 Oct 2020 16:39:11 +0000 Message-ID: References: <83imbse7hi.fsf@gnu.org> <83d01zeplw.fsf@gnu.org> <87mu13ustj.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, eliz@gnu.org, monnier@iro.umontreal.ca To: 43725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 06 18:40:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPq0Y-0009n1-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Oct 2020 18:40:10 +0200 Original-Received: from localhost ([::1]:58898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPq0X-0000NQ-BQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Oct 2020 12:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPq0R-0000N7-4B for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2020 12:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPq0Q-0000g6-R3 for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2020 12:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPq0Q-0001db-Nf for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2020 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2020 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Lars Ingebrigtsen , Eli Zaretskii , 43725@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.16020023646211 (code B ref -1); Tue, 06 Oct 2020 16:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Oct 2020 16:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:54012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPpzo-0001c7-2n for submit@debbugs.gnu.org; Tue, 06 Oct 2020 12:39:24 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:47658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPpzm-0001bz-0g for submit@debbugs.gnu.org; Tue, 06 Oct 2020 12:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPpzl-0000L9-PR for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2020 12:39:21 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:60115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPpzj-0000a3-HS; Tue, 06 Oct 2020 12:39:21 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 096GdB8p020438; Tue, 6 Oct 2020 16:39:11 GMT In-Reply-To: (Andrea Corallo via's message of "Sat, 03 Oct 2020 18:40:30 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/06 12:39:14 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189918 Archived-At: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Lars Ingebrigtsen writes: > >> Eli Zaretskii writes: >> >>>> Mmmh, I think technically we could, similarly to what we do for the >>>> advice, synthesize compile and install a trampoline. This would read >>>> the symbol-function and calls what's in inside. >>>> >>>> This trampoline installation would be triggered inside Ffset. >>>> >>>> So yeah I think we could, if that's the preferred way I can try this >>>> way. >>> >>> Lars, Stefan: do you agree that this is the preferred way? >> >> I'm not really qualified to have an opinion here, but if this allows >> redefining primitives, I'm all for it. Redefining primitives is a >> useful tool. >> >> Would these trampolines be installed only if the primitives are >> redefined, so there'd be no performance impact on code running normally? > > That's correct. > > I did some experimentation today and also the implementation was easy as > the trampoline to be synthesized is exactly the same to what we > synthesize already for advising, essentially I just had to add the > proper trigger in fset. > > At this point I'm also for going this way as it just reduce the > incompatibly surface and I don't see considerable downsides. > > Andrea As my understanding is that that's the consensus I've pushed the revert of those changes in the testsuite and made Ffset effective also for redefining primitives. FYI with the last tweaks `make check` is clean. Andrea