From: Andrea Corallo <akrl@sdf.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 41357@debbugs.gnu.org
Subject: bug#41357: 28.0.50; GC may miss to mark calle safe register content
Date: Sun, 17 May 2020 21:47:12 +0000 [thread overview]
Message-ID: <xjfftby8c9r.fsf@sdf.org> (raw)
In-Reply-To: <8f0c7763-9210-aa29-7cee-945b8494d827@cs.ucla.edu> (Paul Eggert's message of "Sun, 17 May 2020 09:46:23 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 5/17/20 9:40 AM, Andrea Corallo wrote:
>> I think this is a real bug that we have in the codebase (emacs-27
>> included).
>
> Thanks for all the detective work! Your analysis is correct and your patch looks
> good. I've always been suspicious of that code, and it looks like you've
> confirmed my suspicions.
>
> The only question in my mind is whether to install the patch into the emacs-27
> branch or the master branch. Given Eli's problems with stability in emacs-27
> (see Bug#41321), I'm inclined to think the former, as the bug could explain the
> problems Eli is observing.
Hi Paul,
I'm glad you liked the investigation.
I've pushed the fix on master as Eli suggested, feel free to improve it
in case.
I hope a different agreement can be found for 27, in case I'll port it
there.
Thanks!
Andrea
--
akrl@sdf.org
next prev parent reply other threads:[~2020-05-17 21:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 12:42 bug#41357: 28.0.50; GC may miss to mark calle safe register content Andrea Corallo
2020-05-17 15:36 ` Eli Zaretskii
2020-05-17 16:40 ` Andrea Corallo
2020-05-17 16:46 ` Paul Eggert
2020-05-17 17:00 ` Pip Cet
2020-05-17 19:01 ` Paul Eggert
2020-05-17 19:19 ` Eli Zaretskii
2020-05-17 20:23 ` Andrea Corallo
2020-05-17 21:03 ` Paul Eggert
2020-05-17 17:04 ` Eli Zaretskii
2020-05-17 17:21 ` Andrea Corallo
2020-05-17 17:28 ` Eli Zaretskii
2020-05-17 21:27 ` Paul Eggert
2020-05-17 21:47 ` Andrea Corallo [this message]
2020-05-17 17:04 ` Eli Zaretskii
2020-05-17 17:08 ` Paul Eggert
2020-05-17 17:24 ` Eli Zaretskii
2020-05-17 19:05 ` Paul Eggert
2020-05-17 19:26 ` Eli Zaretskii
2020-05-17 19:46 ` Andrea Corallo
2020-05-17 21:21 ` Paul Eggert
2020-05-17 17:13 ` Andrea Corallo
2020-05-17 17:22 ` Eli Zaretskii
2020-05-17 17:45 ` Andrea Corallo
2020-05-17 17:57 ` Eli Zaretskii
2020-05-17 18:16 ` Andrea Corallo
2020-05-25 2:09 ` Tom Tromey
2020-05-25 8:37 ` Andrea Corallo
2020-05-28 22:08 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfftby8c9r.fsf@sdf.org \
--to=akrl@sdf.org \
--cc=41357@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).