From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44209: 28.0.50; [feature/native-comp] Compilation failure in progmodes/js.el Date: Sun, 25 Oct 2020 21:43:44 +0000 Message-ID: References: <87imaybg4o.fsf@gnus.org> <874kmi9yd5.fsf@gnus.org> <87v9ey8i2t.fsf@gnus.org> <87o8kq8esy.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19331"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrew Whatson , 44209@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 25 22:44:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWnoA-0004uu-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 22:44:10 +0100 Original-Received: from localhost ([::1]:38258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWno9-0005I3-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 17:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWno2-0005GT-Pq for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 17:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWno2-0006dJ-Gs for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 17:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWno2-0007xN-DP for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 17:44:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2020 21:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 44209-submit@debbugs.gnu.org id=B44209.160366223130561 (code B ref 44209); Sun, 25 Oct 2020 21:44:02 +0000 Original-Received: (at 44209) by debbugs.gnu.org; 25 Oct 2020 21:43:51 +0000 Original-Received: from localhost ([127.0.0.1]:37882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWnnr-0007wr-8o for submit@debbugs.gnu.org; Sun, 25 Oct 2020 17:43:51 -0400 Original-Received: from mab.sdf.org ([205.166.94.33]:32958 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWnnn-0007wg-Jn for 44209@debbugs.gnu.org; Sun, 25 Oct 2020 17:43:50 -0400 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kWnnk-00013y-FU; Sun, 25 Oct 2020 21:43:44 +0000 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191541 Archived-At: Okay I think I see what is going on: We fail to inline `cc-bytecomp-is-compiling' inside cc-defs.el because `cc-bytecomp-is-compiling' is native compiled even if it should not. We do not native compile defsubsts so they can be disassebled by the bytecompiler to have the inlining performed effectively. Prove of this is that adding (declare (speed -1)) to `cc-bytecomp-is-compiling' to prevent native compialtion fix the issue. Now why defsubst is failing to do the same automatically is another question I have to look into. I suspect this issue is also the cause of some of the warnings we see during the native build. Andrea