From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: akrl--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45934: native-comp - Dylib ID of ELN files not optimal Date: Fri, 29 Jan 2021 08:52:17 +0000 Message-ID: References: <34A641C2-F9E7-487F-8998-D0BC416402FB@yahoo.it> <14FA30A6-E8CC-4A7D-9F40-954515F814D9@yahoo.it> <83v9bgxlqu.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: davide.restivo@yahoo.it, 45934@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 29 09:53:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5PX0-00044m-6n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 09:53:30 +0100 Original-Received: from localhost ([::1]:35264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5PWz-00012l-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 03:53:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5PWY-0000UZ-1q for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 03:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5PWX-0002Xe-QO for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 03:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5PWX-00071C-PA for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 03:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jan 2021 08:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45934 X-GNU-PR-Package: emacs Original-Received: via spool by 45934-submit@debbugs.gnu.org id=B45934.161191034626937 (code B ref 45934); Fri, 29 Jan 2021 08:53:01 +0000 Original-Received: (at 45934) by debbugs.gnu.org; 29 Jan 2021 08:52:26 +0000 Original-Received: from localhost ([127.0.0.1]:51126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5PVx-00070O-Lr for submit@debbugs.gnu.org; Fri, 29 Jan 2021 03:52:26 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:59268 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5PVw-00070G-Al for 45934@debbugs.gnu.org; Fri, 29 Jan 2021 03:52:24 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1l5PVp-0005cW-Vx; Fri, 29 Jan 2021 08:52:18 +0000 In-Reply-To: <83v9bgxlqu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Jan 2021 09:09:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198860 Archived-At: Eli Zaretskii writes: >> Date: Thu, 28 Jan 2021 21:59:16 +0000 >> Cc: 45934@debbugs.gnu.org >> From: akrl--- via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> +/* On MacOS set a unique dylib ID (Bug#45934). */ >> +#if defined (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option) \ >> + && defined (DARWIN_OS) >> + gcc_jit_context_add_driver_option ( >> + comp.ctxt, >> + SSDATA (concat2 (build_string ("-install_name "), >> + Ffile_name_nondirectory (filename)))); >> +#endif > > A minor nit unrelated to the issue at hand: if you take care to > mention the bug number in the commit log message, there's no need to > do that in the comments. > > In general, I don't think it's a good idea to have our sources full of > references to bug reports; if the comment by itself doesn't explain > the underlying issue, it is better to enhance the comment to be > self-contained. IMO, a reference to a bug in the comments is only > justified when the issue is so complicated to explain that having such > an explanation in comments is impractical. > > TIA SGTM, I'll update the patch at the next iteration or before pushing it. Thanks Andrea