From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#40838: 28.0.50; [feature/native-comp] Function overrides in init.el are not honored after deferred compilation Date: Mon, 18 May 2020 21:01:06 +0000 Message-ID: References: <87zhb0q8wi.fsf@localhost> <87lfmidexg.fsf@localhost> <87mu6v4qss.fsf@localhost> <87wo592rne.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="70769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 40838@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 18 23:02:41 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jamuG-000IEe-7I for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 May 2020 23:02:40 +0200 Original-Received: from localhost ([::1]:52488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jamuF-0001Gg-8M for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 May 2020 17:02:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jamte-0001Ef-Al for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 17:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jamte-0000Jy-0V for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 17:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jamtd-0000lq-Ux for bug-gnu-emacs@gnu.org; Mon, 18 May 2020 17:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 May 2020 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40838 X-GNU-PR-Package: emacs Original-Received: via spool by 40838-submit@debbugs.gnu.org id=B40838.15898356692890 (code B ref 40838); Mon, 18 May 2020 21:02:01 +0000 Original-Received: (at 40838) by debbugs.gnu.org; 18 May 2020 21:01:09 +0000 Original-Received: from localhost ([127.0.0.1]:48385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jamsn-0000kY-K9 for submit@debbugs.gnu.org; Mon, 18 May 2020 17:01:09 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:63025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jamsm-0000kP-IR for 40838@debbugs.gnu.org; Mon, 18 May 2020 17:01:09 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04IL17o2022519 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 18 May 2020 21:01:07 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04IL16tu018844; Mon, 18 May 2020 21:01:06 GMT In-Reply-To: (Andrea Corallo's message of "Mon, 18 May 2020 20:15:31 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180561 Archived-At: Andrea Corallo writes: > Okay I think I've an idea of what is going on here. > > straight given wants to build org in a way org is not made for is > hacking around the problem predefining in the compilation environment > `org-release' and `org-git-version'. > > When org.el is loaded is executing at top level the expansion of > `org-check-version' that is supposed to define these two functions, > given are already defined by straight.el we should fall in the first if > clause an the hacked functions remains. > > When the eln are compiled by deferred-compilation no-one is hacking the > definition of these two functions in the way straight.el would like and > so the trouble raise. > > In summary this is not a problem of the deferred compilation mechanism > but is an hack that is not working for this case. > > To mitigate this I've added a new customize you can use to define those > functions (or whatever) into the compiler environment of the async > compilation workers, is called `comp-async-env-modifier-form'. > > 2ac6194585 * Add new customize `comp-async-env-modifier-form' (Bug#40838) > > I'm for closing this. > > Bests > > Andrea Wow I see now straight.el has a branch to support native-comp, kudos to them! https://github.com/flatwhatson/straight.el/tree/native-comp I'll ping them to signal this new customize. Andrea -- akrl@sdf.org