From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47067: 28.0.50; [feature/native-comp] Crash while scrolling through dispnew.c Date: Sun, 14 Mar 2021 08:02:22 +0000 Message-ID: References: <83sg52lykn.fsf@gnu.org> <83mtv8jgn2.fsf@gnu.org> <834khfjv7q.fsf@gnu.org> <83tupfia1m.fsf@gnu.org> <83mtv7hy5c.fsf@gnu.org> <83k0qbhvnh.fsf@gnu.org> <83czw3hu5f.fsf@gnu.org> <83k0qagtfe.fsf@gnu.org> <83im5ugpym.fsf@gnu.org> <83czw2gopq.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3288"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: pipcet@gmail.com, 47067@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 14 09:03:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLLiT-0000jM-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 09:03:13 +0100 Original-Received: from localhost ([::1]:48372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLLiS-0004LH-C0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 04:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLLiK-0004L7-1N for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 04:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLLiJ-0006Ay-5Z for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 04:03:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLLiI-0000xB-Vl for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 04:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2021 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47067 X-GNU-PR-Package: emacs Original-Received: via spool by 47067-submit@debbugs.gnu.org id=B47067.16157089483615 (code B ref 47067); Sun, 14 Mar 2021 08:03:02 +0000 Original-Received: (at 47067) by debbugs.gnu.org; 14 Mar 2021 08:02:28 +0000 Original-Received: from localhost ([127.0.0.1]:32907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLLhk-0000wF-9F for submit@debbugs.gnu.org; Sun, 14 Mar 2021 04:02:28 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:55741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLLhf-0000vx-UC for 47067@debbugs.gnu.org; Sun, 14 Mar 2021 04:02:27 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12E82Mp8005458 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 14 Mar 2021 08:02:23 GMT In-Reply-To: <83czw2gopq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Mar 2021 09:48:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202347 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: pipcet@gmail.com, 47067@debbugs.gnu.org >> Date: Sun, 14 Mar 2021 07:31:14 +0000 >> >> >> >> > >> > Shouldn't that bump the ABI number as well? >> >> Right good point I think it should. >> >> Anyway thinking about: this should be good for a quick test maybe >> removing (or renaming) the discussed .eln. But if it proves this to be >> the bug you'll have to rebuild from scratch to have a reliable system >> anyway , as the ABI number will not cover us for the native code that >> was already dumped with the image. > > Sorry, I don't understand: what is the procedure for testing this > patch? > > I thought I should do this, in the order specified: > > . apply the patch > . increase the ABI version > . rebuild Emacs > . natively-compile all the preloaded Lisp files, then redump Emacs > . visit a C file and let Emacs native-compile all the cc-*.el files > . restart Emacs and try reproducing the crash Yeah this would be 100% the proper way... Given the function potentially miscompiled has been isolated I was suggesting just to have a quick confirmation doing: - apply the patch - "make" so we have the new compiler working - rename the .eln containing the maybe miscompiled function so that is not loaded - start Emacs and load cc-mode so the file gets native compiled - when this is done (the maybe miscompiled function will be native) try to reproduce on dispnew.c If this gets further with no crash should be prove that now the function is working properly. Indeed as you suggest to have a relialble system and probably to do a more certain test the full procedure you mentioned will in case be necessary. Thanks Andrea