From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#56988: Add call-interactively to "never optimize" list for native compilation Date: Fri, 05 Aug 2022 10:07:46 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25292"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 56988@debbugs.gnu.org To: Lynn Winebarger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 05 12:16:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJuNQ-0006RM-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 12:16:20 +0200 Original-Received: from localhost ([::1]:33296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJuNP-0007YC-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Aug 2022 06:16:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJuFO-0006gw-7U for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJuFN-000648-Uq for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJuFN-0000GK-JD for bug-gnu-emacs@gnu.org; Fri, 05 Aug 2022 06:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Aug 2022 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56988 X-GNU-PR-Package: emacs Original-Received: via spool by 56988-submit@debbugs.gnu.org id=B56988.1659694069988 (code B ref 56988); Fri, 05 Aug 2022 10:08:01 +0000 Original-Received: (at 56988) by debbugs.gnu.org; 5 Aug 2022 10:07:49 +0000 Original-Received: from localhost ([127.0.0.1]:56308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuFB-0000Fs-IA for submit@debbugs.gnu.org; Fri, 05 Aug 2022 06:07:49 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:60698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuF9-0000Fj-DB for 56988@debbugs.gnu.org; Fri, 05 Aug 2022 06:07:48 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 275A7koS029570 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 5 Aug 2022 10:07:46 GMT In-Reply-To: (Lynn Winebarger's message of "Thu, 4 Aug 2022 21:37:13 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238851 Archived-At: Lynn Winebarger writes: > Version 28.1: > Since dumping an Emacs with ~500 core libraries in addition to the 100+ from loadup (596 NCUs in the dump), I noticed > huge numbers of async jobs compiling trampolines for call-interactively. Adding call-interactively - and > funcall-interactively for good measure - to the customization variable for functions to never optimize, as well as to the > hard-coded list in advice--add-function, then recompiling and dumping resolved the issue. Hi Lynn, I think we want to keep on optimizing `call-interactively' as changing this policy this could have a negative performance impact in certain scenarios. Perhaps should be investigated why on the process you are engineering this is happening, and modify it so that only one trampoline is compiled. Best Regards Andrea