unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Lynn Winebarger <owinebar@gmail.com>
Cc: 56988@debbugs.gnu.org
Subject: bug#56988: Add call-interactively to "never optimize" list for native compilation
Date: Fri, 05 Aug 2022 10:07:46 +0000	[thread overview]
Message-ID: <xjfedxvj959.fsf@ma.sdf.org> (raw)
In-Reply-To: <CAM=F=bCXOJ04mw-u5mg=yBYx8yc8Sp16ujNacJf9MtNunT_Y3Q@mail.gmail.com> (Lynn Winebarger's message of "Thu, 4 Aug 2022 21:37:13 -0400")

Lynn Winebarger <owinebar@gmail.com> writes:

> Version 28.1:
> Since dumping an Emacs with ~500 core libraries in addition to the 100+ from loadup (596 NCUs in the dump), I noticed
> huge numbers of async jobs compiling trampolines for call-interactively.  Adding call-interactively - and
> funcall-interactively for good measure - to the customization variable for functions to never optimize, as well as to the
> hard-coded list in advice--add-function, then recompiling and dumping resolved the issue.

Hi Lynn,

I think we want to keep on optimizing `call-interactively' as changing
this policy this could have a negative performance impact in certain
scenarios.

Perhaps should be investigated why on the process you are engineering
this is happening, and modify it so that only one trampoline is
compiled.

Best Regards

  Andrea





  reply	other threads:[~2022-08-05 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  1:37 bug#56988: Add call-interactively to "never optimize" list for native compilation Lynn Winebarger
2022-08-05 10:07 ` Andrea Corallo [this message]
2022-08-05 12:13   ` Lynn Winebarger
2022-08-05 12:18     ` Lars Ingebrigtsen
2022-08-05 12:33       ` Lynn Winebarger
2023-06-07 21:18         ` Andrea Corallo
2022-08-07 11:32       ` Lynn Winebarger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfedxvj959.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=56988@debbugs.gnu.org \
    --cc=owinebar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).