bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

[Omar Polo]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

Tags: patch

TL;DR: on openbsd the various dl* functions are in libc.  The attached
patch drops the -ldl here.

Longer version:

I wanted to try the native-comp.  On OpenBSD gcc 10 isn't available, and
gcc 8 doesn't bundle libgccjit.  I hacked the port of of gcc 8 to
provide also the libgccjit, but even if the "smoke test" worked,
building emacs with gcc8 and libgccjit failed.  (this was a couple of
months ago at least).  Today I gave it another shot and built gcc 10
from sources somewhere in my $HOME, and then managed to get emacs up and
running :)  -- honestly, given the amount of hacks to get gcc10 working
in $HOME I am surprised nothing has exploded yet.

I still get a bunch of warnings (atm *Warnings* is 301 lines long), but
they are related to how I installed libgccjit and gcc10, not emacs
itself.

Anyway, none of the above is really about the patch.  The only real
modification on the emacs side was to drop -ldl (and something related
get getopt_long, but I need to investigate that a bit more).

Thanks


In GNU Emacs 28.0.50 (build 1, x86_64-unknown-openbsd6.8, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-01-12 built on venera
Repository revision: ce0c9c349363b5dbea56f7e32c838a93c729263d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: OpenBSD venera 6.8 GENERIC.MP#223 amd64

Configured using:
 'configure CC=mygcc 'CFLAGS=-I /home/op/opt/gcc10/include/
 -I/usr/include -I/usr/local/include' 'LDFLAGS=-L/usr/lib
 -L/usr/local/lib -L/home/op/opt/gcc10/lib -lmyuglyhack'
 --prefix=/home/op/opt/native-emacs --with-x-toolkit=lucid
 --with-nativecomp --without-makeinfo'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: diff --]
[-- Type: text/patch, Size: 818 bytes --]

diff --git a/configure.ac b/configure.ac
index e3a96a2b69..76ec3d1946 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3820,10 +3820,15 @@ if test "${with_nativecomp}" != "no"; then
     AC_RUN_IFELSE([libgccjit_smoke_test], [], [libgccjit_broken])
     LIBS=$emacs_save_LIBS
     HAVE_NATIVE_COMP=yes
-    # mingw32 loads the library dynamically.
-    if test "${opsys}" != "mingw32"; then
-      LIBGCCJIT_LIB="-lgccjit -ldl"
-    fi
+    case "${opsys}" in
+      # mingw32 loads the library dynamically.
+      mingw32) ;;
+      # OpenBSD doesn't have libdl, all the functions are in libc
+      openbsd)
+        LIBGCCJIT_LIB="-lgccjit" ;;
+      *)
+        LIBGCCJIT_LIB="-lgccjit -ldl" ;;
+    esac
     NEED_DYNLIB=yes
     AC_DEFINE(HAVE_NATIVE_COMP, 1, [Define to 1 if native compiler is available.])
 fi

[-- Attachment #3: Type: text/plain, Size: 16 bytes --]


-- 
/Omar Polo

bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Omar Polo <op@omarpolo.com> writes:

> Tags: patch
>
> TL;DR: on openbsd the various dl* functions are in libc.  The attached
> patch drops the -ldl here.

Hi Omar,

thanks for the patch!

what's the state of your copyright paperwork?

  Andrea

bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

[Omar Polo]

Andrea Corallo <akrl@sdf.org> writes:

> Omar Polo <op@omarpolo.com> writes:
>
>> Tags: patch
>>
>> TL;DR: on openbsd the various dl* functions are in libc.  The attached
>> patch drops the -ldl here.
>
> Hi Omar,
>
> thanks for the patch!
>
> what's the state of your copyright paperwork?
>
>   Andrea

I got it approved just a couple of days ago.  Should I attach the pdf?
If it's enough, I submitted another patch recently[0] that was merged.
(sorry for the probably dumb question, but these are my first
contribution to a GNU project)

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45729

Thanks,

Omar Polo

bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

[Lars Ingebrigtsen]

Omar Polo <op@omarpolo.com> writes:

> I got it approved just a couple of days ago.  Should I attach the pdf?

I can confirm that Omar has copyright assignment papers on file.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#45814: [PATCH] [native-comp] drop -ldl on OpenBSD

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Omar Polo <op@omarpolo.com> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>
>> Omar Polo <op@omarpolo.com> writes:
>>
>>> Tags: patch
>>>
>>> TL;DR: on openbsd the various dl* functions are in libc.  The attached
>>> patch drops the -ldl here.
>>
>> Hi Omar,
>>
>> thanks for the patch!
>>
>> what's the state of your copyright paperwork?
>>
>>   Andrea
>
> I got it approved just a couple of days ago.  Should I attach the pdf?
> If it's enough, I submitted another patch recently[0] that was merged.
> (sorry for the probably dumb question, but these are my first
> contribution to a GNU project)

Nice, so congrats your second patch is in as 79b9a262ff :)

Closing

Thanks

  Andrea

PS Please next time format the patch with git adding a simple Changelog
entry (see "** Commit messages" in CONTRIBUTE).