From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Sun, 14 Feb 2021 20:22:10 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 21:23:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBNvN-00014F-Iw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 21:23:21 +0100 Original-Received: from localhost ([::1]:47416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBNvM-0005O6-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 15:23:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBNv4-0005GA-SU for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 15:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBNv4-0007MQ-LO for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 15:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBNv4-00066R-G7 for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2021 15:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161333413623387 (code B ref 43725); Sun, 14 Feb 2021 20:23:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 14 Feb 2021 20:22:16 +0000 Original-Received: from localhost ([127.0.0.1]:36817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBNuK-000659-Dk for submit@debbugs.gnu.org; Sun, 14 Feb 2021 15:22:16 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:58567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBNuI-00064x-2X for 43725@debbugs.gnu.org; Sun, 14 Feb 2021 15:22:14 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11EKMAdf010265 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 14 Feb 2021 20:22:11 GMT In-Reply-To: <831rdjd95w.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Feb 2021 22:06:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200034 Archived-At: Eli Zaretskii writes: > Andrea, can you please explain why there are so many changes in Lisp > files on the branch? > > For example, what are changes like this one about: > > +(declare-function subr-native-lambda-list "data.c") `subr-native-lambda-list' returns the lambda list for a dynamic native compiled function or t if lexically scoped. This is available only building "--with-nativecomp", this is to remove a bytecompiler warning for vanilla build. > Or this: > > + ((and (featurep 'nativecomp) > + (subrp def) > + (listp (subr-native-lambda-list def))) > + (subr-native-lambda-list def)) This is to retrive the lambda list of dynamic scoped native compiled lisp function so that `help-function-arglist' can return it. > Or this: > > + ;; Never native compile to allow cc-defs.el:2345 hack. > + (declare (speed -1)) cc-defs does a dirty hack where is capturing the bytecode object of `cc-bytecomp-compiling-or-loading'. >From cc-defs.el: ======== ;; Ugly hack to pull in the definition of `cc-bytecomp-compiling-or-loading' ;; from cc-bytecomp to make it available at loadtime. This is the same ;; mechanism used in cc-mode.el for `c-populate-syntax-table'. (defalias 'cc-bytecomp-compiling-or-loading (cc-eval-when-compile (let ((f (symbol-function 'cc-bytecomp-compiling-or-loading))) (if (byte-code-function-p f) f (byte-compile f))))) ======== Native code cannot go through the read print loop so this hack can't work native compiling the function, speed -1 ensure the function is present in the eln file but in form of bytecode. > This will not work on MS-Windows, you need to use path-separator to do > it portably: > > + (when (featurep 'nativecomp) > + (defvar comp-eln-load-path) > + (let ((path-env (getenv "EMACSNATIVELOADPATH"))) > + (when path-env > + (dolist (path (split-string path-env ":")) <<<<<<<<<<<<< > + (unless (string= "" path) > + (push path comp-eln-load-path))))) > + (push (concat user-emacs-directory "eln-cache/") comp-eln-load-path)) Fixed by 31416495ad. I'll keep on working through your points the coming week, sincere thanks for reviewing. Andrea