unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Sun, 14 Feb 2021 20:22:10 +0000	[thread overview]
Message-ID: <xjfczx2tn65.fsf@sdf.org> (raw)
In-Reply-To: <831rdjd95w.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Feb 2021 22:06:51 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> Andrea, can you please explain why there are so many changes in Lisp
> files on the branch?
>
> For example, what are changes like this one about:
>
>   +(declare-function subr-native-lambda-list "data.c")

`subr-native-lambda-list' returns the lambda list for a dynamic native
compiled function or t if lexically scoped.

This is available only building "--with-nativecomp", this is to remove a
bytecompiler warning for vanilla build.  

> Or this:
>
>   +   ((and (featurep 'nativecomp)
>   +         (subrp def)
>   +         (listp (subr-native-lambda-list def)))
>   +    (subr-native-lambda-list def))

This is to retrive the lambda list of dynamic scoped native compiled
lisp function so that `help-function-arglist' can return it.

> Or this:
>
>   +  ;; Never native compile to allow cc-defs.el:2345 hack.
>   +  (declare (speed -1))

cc-defs does a dirty hack where is capturing the bytecode object of
`cc-bytecomp-compiling-or-loading'.

From cc-defs.el:
========
;; Ugly hack to pull in the definition of `cc-bytecomp-compiling-or-loading'
;; from cc-bytecomp to make it available at loadtime.  This is the same
;; mechanism used in cc-mode.el for `c-populate-syntax-table'.
(defalias 'cc-bytecomp-compiling-or-loading
  (cc-eval-when-compile
    (let ((f (symbol-function 'cc-bytecomp-compiling-or-loading)))
      (if (byte-code-function-p f) f (byte-compile f)))))
========

Native code cannot go through the read print loop so this hack can't
work native compiling the function, speed -1 ensure the function is
present in the eln file but in form of bytecode.

> This will not work on MS-Windows, you need to use path-separator to do
> it portably:
>
>   +    (when (featurep 'nativecomp)
>   +      (defvar comp-eln-load-path)
>   +      (let ((path-env (getenv "EMACSNATIVELOADPATH")))
>   +        (when path-env
>   +          (dolist (path (split-string path-env ":")) <<<<<<<<<<<<<
>   +            (unless (string= "" path)
>   +              (push path comp-eln-load-path)))))
>   +      (push (concat user-emacs-directory "eln-cache/") comp-eln-load-path))

Fixed by 31416495ad.

I'll keep on working through your points the coming week, sincere thanks
for reviewing.

  Andrea





  reply	other threads:[~2021-02-14 20:22 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 15:44 bug#43725: 28.0.50; Include feature/native-comp into master Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-30 17:27 ` Lars Ingebrigtsen
2020-09-30 22:37   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01  1:34     ` Lars Ingebrigtsen
2020-10-01  7:51       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 13:13         ` Eli Zaretskii
2020-10-01 13:40           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 15:55           ` Lars Ingebrigtsen
2020-10-01  2:40     ` Eli Zaretskii
2020-10-02 19:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-02 19:46   ` Eli Zaretskii
2020-10-02 19:58     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-03  7:27       ` Eli Zaretskii
2020-10-03 17:23         ` Lars Ingebrigtsen
2020-10-03 18:40           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-06 16:39             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-07  4:28               ` Lars Ingebrigtsen
2020-10-07 14:47                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-09  4:20                   ` Lars Ingebrigtsen
2020-10-06 17:11         ` Stefan Monnier
2020-11-25 18:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-26 10:10   ` Lars Ingebrigtsen
2020-11-26 11:19     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-26 11:28       ` Lars Ingebrigtsen
2020-11-26 12:02         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-04 22:28           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-06 13:13             ` Lars Ingebrigtsen
2020-11-26 14:17     ` Eli Zaretskii
2020-11-26 21:15       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-27  7:16         ` Eli Zaretskii
2021-02-13 20:06           ` Eli Zaretskii
2021-02-14 20:22             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-02-16 21:13             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-17 15:18               ` Eli Zaretskii
2021-02-18 21:22                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19  8:08                   ` Eli Zaretskii
2021-02-18 20:32               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-18 20:36                 ` Eli Zaretskii
2021-02-18 20:53                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19  7:51                     ` Eli Zaretskii
2021-02-19 11:13                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19 12:23                         ` Eli Zaretskii
2021-02-19 22:03                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-20  6:57                             ` Eli Zaretskii
2021-02-19 12:53                 ` Pip Cet
2021-02-19 13:37                   ` Eli Zaretskii
2021-02-19 14:16                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19 14:23                       ` Pip Cet
2021-02-19 14:35                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19 14:59                           ` Eli Zaretskii
2021-02-19 15:00                           ` Pip Cet
2021-02-19 15:11                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19 17:33                             ` Andy Moreton
2021-02-18 21:56             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19  8:14               ` Eli Zaretskii
2021-02-18 21:58   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19  8:16     ` Eli Zaretskii
2021-02-22 20:08       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-22 20:51         ` Pip Cet
2021-02-23  3:23         ` Eli Zaretskii
2021-02-26 19:31           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 19:13             ` Eli Zaretskii
2021-03-09 19:28               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 19:53                 ` Eli Zaretskii
2021-03-09 20:09                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 13:13                     ` Eli Zaretskii
2021-03-10 13:16                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 15:09                         ` Eli Zaretskii
2021-03-10 15:45                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 16:33                             ` Eli Zaretskii
2021-03-10 16:45                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 17:06                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 17:22                                   ` Eli Zaretskii
2021-03-14 19:06                                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-14 19:51                                       ` Eli Zaretskii
2021-03-14 20:00                                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-15 15:19                                           ` Eli Zaretskii
2021-03-15 15:43                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-15 18:33                                               ` Eli Zaretskii
2021-03-15 20:00                                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-20 11:00                                                   ` Eli Zaretskii
2021-03-20 11:55                                                     ` Eli Zaretskii
2021-03-21  8:32                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-21  9:57                                                         ` Eli Zaretskii
2021-03-15 14:57                                         ` Eli Zaretskii
2021-05-01 18:24 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-01 19:06   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfczx2tn65.fsf@sdf.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=43725@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).