From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45303: #45303 [feature/native-comp] building error on Windows Date: Mon, 21 Dec 2020 08:02:35 +0000 Message-ID: References: <83k0te6c7i.fsf@gnu.org> <86im8w4t7y.fsf@gmail.com> <86v9cw5697.fsf@gmail.com> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25888"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45303@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 21 09:03:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krG9t-0006cG-0O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 09:03:09 +0100 Original-Received: from localhost ([::1]:58552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krG9s-0000PU-2o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 03:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krG9m-0000PN-2G for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 03:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krG9l-0003al-QK for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 03:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krG9l-0000Ei-MM for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 03:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2020 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45303 X-GNU-PR-Package: emacs Original-Received: via spool by 45303-submit@debbugs.gnu.org id=B45303.1608537759878 (code B ref 45303); Mon, 21 Dec 2020 08:03:01 +0000 Original-Received: (at 45303) by debbugs.gnu.org; 21 Dec 2020 08:02:39 +0000 Original-Received: from localhost ([127.0.0.1]:46124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krG9O-0000E6-VU for submit@debbugs.gnu.org; Mon, 21 Dec 2020 03:02:39 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:37752 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krG9M-0000Dx-Mg for 45303@debbugs.gnu.org; Mon, 21 Dec 2020 03:02:37 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1krG9L-0007rq-LJ; Mon, 21 Dec 2020 08:02:35 +0000 In-Reply-To: <86v9cw5697.fsf@gmail.com> (Andy Moreton's message of "Mon, 21 Dec 2020 00:53:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196524 Archived-At: Andy Moreton writes: > On Sun 20 Dec 2020, Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > >> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >> [...] >> >>> Thanks, hope 18ca9ea08a fix it. >> ^^^^^ >> 3bb2fd0c58 > > Thanks Andrea, that problem is fixed. There are still some warnings from > comp.c that indicate other troubles: > > C:/emacs/git/emacs/native/src/comp.c: In function 'Fcomp__compile_ctxt_to_file': > C:/emacs/git/emacs/native/src/comp.c:4461:12: warning: unused variable 'oldset' [-Wunused-variable] > 4461 | sigset_t oldset; > | ^~~~~~ > C:/emacs/git/emacs/native/src/comp.c: In function 'eln_load_path_final_clean_up': > C:/emacs/git/emacs/native/src/comp.c:4626:12: warning: passing argument 7 of 'internal_condition_case_5' from incompatible pointer type [-Wincompatible-pointer-types] > 4626 | Qt, return_nil, Qnil); > | ^~~~~~~~~~ > | | > | struct Lisp_X * (*)(struct Lisp_X *) > In file included from C:/emacs/git/emacs/native/src/comp.c:23: > C:/emacs/git/emacs/native/src/lisp.h:4161:195: note: expected 'Lisp_Object' {aka 'struct Lisp_X *'} but argument is of type 'struct Lisp_X * (*)(struct Lisp_X *)' > 4161 | extern Lisp_Object internal_condition_case_5 (Lisp_Object (*) > (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object), > Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, > Lisp_Object, Lisp_Object (*) (Lisp_Object)); > | ^~~~~~~~~~~ > In file included from C:/emacs/git/emacs/native/src/lisp.h:944, > from C:/emacs/git/emacs/native/src/comp.c:23: > ./globals.h:6980:14: warning: passing argument 8 of 'internal_condition_case_5' from incompatible pointer type [-Wincompatible-pointer-types] > 6980 | #define Qnil builtin_lisp_symbol (0) > | ^~~~~~~~~~~~~~~~~~~~~~~ > | | > | Lisp_Object {aka struct Lisp_X *} > C:/emacs/git/emacs/native/src/comp.c:4626:24: note: in expansion of macro 'Qnil' > 4626 | Qt, return_nil, Qnil); > | ^~~~ > In file included from C:/emacs/git/emacs/native/src/comp.c:23: > C:/emacs/git/emacs/native/src/lisp.h:4161:208: note: expected 'struct Lisp_X * (*)(struct Lisp_X *)' but argument is of type 'Lisp_Object' {aka 'struct Lisp_X *'} > 4161 | extern Lisp_Object internal_condition_case_5 (Lisp_Object (*) > (Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object), > Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, Lisp_Object, > Lisp_Object, Lisp_Object (*) (Lisp_Object)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > The internal_condition_case_5 usage looks like the last two arguments > might be swapped. Right, f4153cac3e and 2526032ea9 should fix those two issues. IIUC compilation-wise we are left only with the zlib issue now. Andrea