From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Sat, 06 Mar 2021 19:31:44 +0000 Message-ID: References: <83h7m84h9g.fsf@gnu.org> <86v9ao5czu.fsf@gmail.com> <86wnutogrh.fsf@gmail.com> <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <83k0qoj9zv.fsf@gnu.org> <83im68j963.fsf@gnu.org> <861rct5dfd.fsf@gmail.com> <83zgzgwww0.fsf@gnu.org> <86sg58wkjp.fsf@gmail.com> <83eegswhy8.fsf@gnu.org> <861rcsl1y1.fsf@gmail.com> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46256@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 20:32:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIcep-0009Mh-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 20:32:11 +0100 Original-Received: from localhost ([::1]:42128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIcep-0002qV-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 14:32:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIceg-0002oe-Hi for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 14:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIceg-0003e9-9i for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIceg-0008Gn-74 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161505911031771 (code B ref 46256); Sat, 06 Mar 2021 19:32:02 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 6 Mar 2021 19:31:50 +0000 Original-Received: from localhost ([127.0.0.1]:38379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIceU-0008GN-69 for submit@debbugs.gnu.org; Sat, 06 Mar 2021 14:31:50 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:58751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIceQ-0008GA-8b for 46256@debbugs.gnu.org; Sat, 06 Mar 2021 14:31:49 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 126JViqO006469 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 6 Mar 2021 19:31:45 GMT In-Reply-To: <861rcsl1y1.fsf@gmail.com> (Andy Moreton's message of "Sat, 06 Mar 2021 15:46:46 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201674 Archived-At: Andy Moreton writes: > On Sat 06 Mar 2021, Eli Zaretskii wrote: > >>> From: Andy Moreton >>> Date: Sat, 06 Mar 2021 12:09:30 +0000 >>> >>> >> Thus the ABI hash should also include `system-configuration-features'. >>> > >>> > Which of the features you think might affect the ABI? I reviewed them >>> > a couple of days ago and didn't find any I could convince myself >>> > should affect that, but maybe I missed something. >>> >>> As a reasonably recent example, adding bignum support by default added >>> "GMP" to `system-configuration-features' when rebuilding after pulling >>> upstream changes, without the user changing the configure command line >>> saved in `system-configuration-options'. >> >> AFAIU, such changes only affect *.eln files if we add new primitives >> to Emacs or change existing primitives, and those changes are already >> captured by the ABI hash. Right? > > Perhaps you are right, but we need some input from Andrea on whether > these changes affect the ABI. Eli is correct. I think we can define the ABI as: 1- the list of all primitives and their signatures. 2- the eln load mechanism we implement. 3- low level details of how Lisp objects are represented in case these are directly manipulated by opencoded code (ATM integer and conses). 1 is accounted automatically in the `comp-abi-hash' computation. For 2 and 3 we are responsible to manually bump a new `comp-abi-hash' (leveraging ABI_VERSION). So yeah I think we should be fine ATM. Thanks Andrea