From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, 59334@debbugs.gnu.org
Subject: bug#59334: 29.0.50; loading native-compiled init file sets user-init-file to .eln
Date: Fri, 18 Nov 2022 20:02:36 +0000 [thread overview]
Message-ID: <xjfbkp4c9pf.fsf@ma.sdf.org> (raw)
In-Reply-To: <83cz9kbfxg.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Nov 2022 14:33:31 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Juanma Barranquero <lekktu@gmail.com>
>> Date: Fri, 18 Nov 2022 10:05:50 +0100
>> Cc: akrl@sdf.org, 59334@debbugs.gnu.org
>>
>> > I thought about a possibility that the session loaded a .eln file, but
>> > then the user or some Lisp explicitly loaded the .el file by hand.
>> > I'm not sure in this case the hash table is updated.
>>
>> That's a whole another problem, isn't it?
>
> Not necessarily.
>
>> On one hand, it would not affect user-init-file, as it's not the
>> usual startup procedure.
>
> It could be part of startup if the forced loading of "init.el" is in
> the code inside user's init file itself. Crazy, I know, but not
> impossible.
>
>> And, on the other hand,
>> my patch sets user-init-file to the source .el, so after reloading that file it would still have the right value,
>> wouldn't it?
>
> If that is the same file, yes. But what if there's an init.el in
> another place?
>
> In any case, we don't need to keep arguing about this, since your
> pat6ch indeed uses gethash only if the init file has the .eln
> extension.
>
>> The original code is untouched, other than changing `when' to `if'; the else part deals with the .eln.
>
> I think we should compare the extensions case-insensitively, but other
> than that, this LGTM.
>
> Andrea, any comments?
Agree and I don't have any further comment.
Thanks
Andrea
next prev parent reply other threads:[~2022-11-18 20:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:28 bug#59334: 29.0.50; loading native-compiled init file sets user-init-file to .eln Juanma Barranquero
2022-11-17 12:07 ` Eli Zaretskii
2022-11-17 13:30 ` Juanma Barranquero
2022-11-17 14:00 ` Eli Zaretskii
2022-11-17 20:04 ` Andrea Corallo
2022-11-17 20:09 ` Eli Zaretskii
2022-11-18 2:25 ` Juanma Barranquero
2022-11-18 2:56 ` Juanma Barranquero
2022-11-18 3:03 ` Juanma Barranquero
2022-11-18 7:50 ` Eli Zaretskii
2022-11-18 7:19 ` Eli Zaretskii
2022-11-18 7:27 ` Eli Zaretskii
2022-11-18 7:45 ` Juanma Barranquero
2022-11-18 8:46 ` Eli Zaretskii
2022-11-18 9:05 ` Juanma Barranquero
2022-11-18 9:08 ` Juanma Barranquero
2022-11-18 12:33 ` Eli Zaretskii
2022-11-18 12:40 ` Juanma Barranquero
2022-11-18 12:50 ` Eli Zaretskii
2022-11-18 13:03 ` Juanma Barranquero
2022-11-18 20:02 ` Andrea Corallo [this message]
2022-11-18 10:39 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfbkp4c9pf.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=59334@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).