From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Fri, 10 Feb 2023 16:46:57 +0000 Message-ID: References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1914"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56682@debbugs.gnu.org, Gregory Heytings , monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 10 17:47:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQWYY-0000Gd-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Feb 2023 17:47:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQWYG-0006ra-TP; Fri, 10 Feb 2023 11:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQWYD-0006rM-VT for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 11:47:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQWYA-00024k-Bo for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 11:47:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQWYA-00019u-7e for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2023 11:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2023 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16760476214446 (code B ref 56682); Fri, 10 Feb 2023 16:47:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 10 Feb 2023 16:47:01 +0000 Original-Received: from localhost ([127.0.0.1]:37990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQWY9-00019d-3D for submit@debbugs.gnu.org; Fri, 10 Feb 2023 11:47:01 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:58992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQWY6-00019U-Dg for 56682@debbugs.gnu.org; Fri, 10 Feb 2023 11:46:59 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 31AGkufW014267 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 10 Feb 2023 16:46:57 GMT In-Reply-To: <83357fnwyy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Feb 2023 09:01:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255294 Archived-At: Eli Zaretskii writes: >> Date: Thu, 09 Feb 2023 01:57:50 +0000 >> From: Gregory Heytings >> cc: monnier@iro.umontreal.ca, 56682@debbugs.gnu.org >> >> >> As promised, I worked on this. Alas, while doing that I found out that >> the existing code had a grave bug, which I corrected. However, this >> touches src/bytecode.c, lisp/emacs-lisp/bytecomp.el and src/comp.c, so I'm >> (to say the least) uncomfortable pushing that fix to emacs-29. The result >> of the bug fix, a few renames, the documentation update, and an added >> test, is in scratch/fix-locked-narrowing. I did a make bootstrap and a >> make check after each step, all of them succeeded. > > Thanks. > > Please describe the bug you discovered and the changes made to fix it > (and maybe also alternatives if you considered them). It is not easy > to glean that information from the changes, as they involve also > renaming of variables (which, at this late stage, I don't think you > should have done without discussion, btw), documentation changes, and > perhaps more. > > Also, did you test this both with and without native-compilation? > > Andrea, could you please see if the changes on that branch are okay as > far as native-compilation is concerned? As far as I can see LGTM. The branch should be okay as long as it's bootstrapped and we have no regressions in the testsuite. Best Regards Andrea