From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Sat, 03 Oct 2020 18:40:30 +0000 Message-ID: References: <83imbse7hi.fsf@gnu.org> <83d01zeplw.fsf@gnu.org> <87mu13ustj.fsf@gnus.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Stefan Monnier , 43725@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 03 20:41:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOmTA-0001Gz-M2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 20:41:20 +0200 Original-Received: from localhost ([::1]:49962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOmT9-0002Aa-Ou for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 14:41:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOmSs-0002AG-GD for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOmSs-0001Yv-28 for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOmSs-0001am-0i for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 18:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.16017504346079 (code B ref 43725); Sat, 03 Oct 2020 18:41:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 3 Oct 2020 18:40:34 +0000 Original-Received: from localhost ([127.0.0.1]:44470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmSP-0001Zz-O6 for submit@debbugs.gnu.org; Sat, 03 Oct 2020 14:40:34 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:54851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmSN-0001Zq-Ce for 43725@debbugs.gnu.org; Sat, 03 Oct 2020 14:40:32 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 093IeUtU029374; Sat, 3 Oct 2020 18:40:30 GMT In-Reply-To: <87mu13ustj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 03 Oct 2020 19:23:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189721 Archived-At: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >>> Mmmh, I think technically we could, similarly to what we do for the >>> advice, synthesize compile and install a trampoline. This would read >>> the symbol-function and calls what's in inside. >>> >>> This trampoline installation would be triggered inside Ffset. >>> >>> So yeah I think we could, if that's the preferred way I can try this >>> way. >> >> Lars, Stefan: do you agree that this is the preferred way? > > I'm not really qualified to have an opinion here, but if this allows > redefining primitives, I'm all for it. Redefining primitives is a > useful tool. > > Would these trampolines be installed only if the primitives are > redefined, so there'd be no performance impact on code running normally? That's correct. I did some experimentation today and also the implementation was easy as the trampoline to be synthesized is exactly the same to what we synthesize already for advising, essentially I just had to add the proper trigger in fset. At this point I'm also for going this way as it just reduce the incompatibly surface and I don't see considerable downsides. Andrea