From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Mon, 15 Mar 2021 20:00:17 +0000 Message-ID: References: <83k0qzv54q.fsf@gnu.org> <83lfawp2cc.fsf@gnu.org> <83k0qgp0hj.fsf@gnu.org> <837dmfp2x7.fsf@gnu.org> <83v99znizq.fsf@gnu.org> <83o8frnf2r.fsf@gnu.org> <83r1khfy5d.fsf@gnu.org> <83k0q9fr91.fsf@gnu.org> <838s6ofnr7.fsf@gnu.org> <83y2eoe071.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 15 21:02:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLtQB-0008wa-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Mar 2021 21:02:35 +0100 Original-Received: from localhost ([::1]:58906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLtQA-00050c-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Mar 2021 16:02:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLtOh-0003gL-7k for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2021 16:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLtOf-0000s7-Qb for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2021 16:01:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLtOf-0007vj-O3 for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2021 16:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Mar 2021 20:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161583842430433 (code B ref 43725); Mon, 15 Mar 2021 20:01:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 15 Mar 2021 20:00:24 +0000 Original-Received: from localhost ([127.0.0.1]:37257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLtO4-0007un-0O for submit@debbugs.gnu.org; Mon, 15 Mar 2021 16:00:24 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:54855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLtNz-0007uc-Rt for 43725@debbugs.gnu.org; Mon, 15 Mar 2021 16:00:22 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12FK0HrN023830 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 15 Mar 2021 20:00:18 GMT In-Reply-To: <83y2eoe071.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Mar 2021 20:33:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202427 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org >> Date: Mon, 15 Mar 2021 15:43:07 +0000 >> >> Eli Zaretskii writes: >> >> > The issue is this: our Lisp files are generally encoded in UTF-8. But >> > there's no guarantee that GCC expects the source to be encoded in >> > UTF-8. If the text we submit to libgccjit for compilation is in the >> > same encoding as the original .el files, then shouldn't we tell GCC >> > its actual encoding, to make sure non-ASCII text aren't mangled? >> >> The only generated text we are passing to libgccjit is feed to >> 'gcc_jit_context_new_string_literal'. > > What kind of "string literals" go this way? Are these constant > strings from Lisp, or can some other data types from Lisp end up being > passed like that? This are essentially all Lisp objects that we'd put in the constant vector for the bytecode case. >> This text is generated from 'Fprin1_to_string' that we use to >> essentially render in form of text immediate objects. I thought >> this was disconnected from the encoding of the source file, am I >> wrong? > > If the original text is from Lisp strings in the Lisp source file, > then it isn't disconnected. Those strings could include non-ASCII > characters, and they come out in UTF-8 (well, almost, modulo the raw > bytes etc.). In december I've fixed a bug for multibyte strings adding also a testcase for that. This was bug#45342 and the commit fixing and adding the testcase is 72c1a41573. I'm no big expert into this area so you might want to have a look to the commit to suggets if this covers already the case you are suggesting or not. Thanks! Andrea