From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows Date: Sat, 23 May 2020 11:21:03 +0000 Message-ID: References: <83k11e4a0s.fsf@gnu.org> <83blmp4tob.fsf@gnu.org> <83o8qp1hfr.fsf@gnu.org> <837dxcv1po.fsf@gnu.org> <83imgvdf94.fsf@gnu.org> <83eerjde6k.fsf@gnu.org> <83a7227hkb.fsf@gnu.org> <83blmf13d1.fsf@gnu.org> <83367r0zvb.fsf@gnu.org> <83zh9yzzeg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100094"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: nicolasbertolo@gmail.com, 41242@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 23 13:22:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcSEK-000Pui-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 13:22:16 +0200 Original-Received: from localhost ([::1]:55750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcSEJ-0000Mz-LD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 07:22:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcSE7-0000FV-H1 for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcSE6-0002SH-JQ for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcSE6-0007XM-Ex for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 07:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2020 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159023287028906 (code B ref 41242); Sat, 23 May 2020 11:22:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 23 May 2020 11:21:10 +0000 Original-Received: from localhost ([127.0.0.1]:33522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcSDF-0007WA-NF for submit@debbugs.gnu.org; Sat, 23 May 2020 07:21:10 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:56738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcSDB-0007Vz-Dt for 41242@debbugs.gnu.org; Sat, 23 May 2020 07:21:08 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04NBL4Oj007930 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 23 May 2020 11:21:04 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04NBL3W5003045; Sat, 23 May 2020 11:21:03 GMT In-Reply-To: <83zh9yzzeg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 May 2020 14:03:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180790 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: nicolasbertolo@gmail.com, 41242@debbugs.gnu.org >> Date: Sat, 23 May 2020 10:37:18 +0000 >> >> >> https://akrl.sdf.org/gccemacs.html#orgb063106 >> > >> > Thanks. I guess this changes a lot in how Emacs starts up? E.g., >> > what happens if the .el file was in the meantime modified and >> > recompiled into the .eln file? we will load the new versions instead >> > of the one that was preloaded, right? >> >> This is something we have to define. Currently we only complain if one >> of the defined functions that was dumped cannot be found in the new >> .eln. My preference would be to sign each .eln used for dump to make >> sure what we are loading is what we dumped and refuse to load otherwise. >> >> BTW reloading from dump the "dumped" eln are not located by searching in >> the load-path for all suffix. The eln position is stored into the >> compilation unit object for performance reasons. > > Are you saying we store the absolute file name of the .eln files in > the pdumper file? If so, how can Emacs start up if the .eln files > were moved to another location, e.g. as part of "make install", or > more generally if Emacs was relocated since it was dumped? To be precise we store the relative path of the .eln from the emacs executable, both for the local build both for the file position we will have after a "make install". Reloading the first compilation unit the code detect in which of this two cases we are (this is where file-exists is called) and this information is used for all the following compilaiton unit to be revived. >> The performance problem Nicolas is discussing is related to the non >> dumped .elns loaded at startup I believe. > > This is not about the performance issue, this is about the crash > because emacs_dir was not yet defined where Emacs needed it: a > different issue uncovered by Nicolas. Ops got confused between the two branches of this same thread. -- akrl@sdf.org