From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46670: 28.0.50; [feature/native-comp] possible miscompilation affecting lsp-mode Date: Mon, 22 Feb 2021 11:23:49 +0000 Message-ID: References: <87a6ry46uc.fsf@collares.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31998"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46670@debbugs.gnu.org, Mauricio Collares To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 22 12:24:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lE9Jy-0008C2-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Feb 2021 12:24:10 +0100 Original-Received: from localhost ([::1]:45770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lE9Jx-0000df-0K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Feb 2021 06:24:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lE9Jp-0000cc-UL for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2021 06:24:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lE9Jp-0002kF-Na for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2021 06:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lE9Jp-0008W2-Jm for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2021 06:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Feb 2021 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46670 X-GNU-PR-Package: emacs Original-Received: via spool by 46670-submit@debbugs.gnu.org id=B46670.161399303632723 (code B ref 46670); Mon, 22 Feb 2021 11:24:01 +0000 Original-Received: (at 46670) by debbugs.gnu.org; 22 Feb 2021 11:23:56 +0000 Original-Received: from localhost ([127.0.0.1]:55830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE9Jk-0008Vi-7E for submit@debbugs.gnu.org; Mon, 22 Feb 2021 06:23:56 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:50408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lE9Ji-0008Va-C9 for 46670@debbugs.gnu.org; Mon, 22 Feb 2021 06:23:54 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11MBNnHb013880 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 22 Feb 2021 11:23:50 GMT In-Reply-To: (Pip Cet's message of "Mon, 22 Feb 2021 10:25:28 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200559 Archived-At: Pip Cet writes: > On Mon, Feb 22, 2021 at 10:04 AM Pip Cet wrote: > >> > BTW applying your patch >> > is breaking quite some of the comp-tests-ret-type-spec-* tests :) >> >> Where do you keep those? > > Oh, I see, they're written as though they tested comp.c. > > At a quick glance, the test results aren't actually incorrect, they're > merely missed optimizations. Correct, note these is not only about potentially missed optimizations, we expose the derived return type with `subr-type' and in the future we might give it even more visibility (like using it it in the C-h f output). > (Except for this one: > > ((defun comp-tests-ret-type-spec-f (x) > (unless (symbolp x) > x)) > (not symbol)) > > If I'm reading that correctly, it tests that (unless (symbolp x) x) > isn't a symbol, which it usually is) Yep, it verifies that this function has as inferred return type (not symbol). Andrea