unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: max.brieiev@gmail.com, larsi@gnus.org, 58429@debbugs.gnu.org
Subject: bug#58429: 29.0.50; inhibit-automatic-native-compilation does not work as expected.
Date: Fri, 14 Oct 2022 20:10:57 +0000	[thread overview]
Message-ID: <xjf5ygmyxm6.fsf@ma.sdf.org> (raw)
In-Reply-To: <83h707aevl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Oct 2022 19:05:02 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: Eli Zaretskii <eliz@gnu.org>, larsi@gnus.org, 58429@debbugs.gnu.org
>> Date: Thu, 13 Oct 2022 14:10:52 +0000
>> 
>> As Eli mentioned unfortunately we cannot disable trampolines.
>
> Btw, Andrea, can you help me understand better what does
> comp-enable-subr-trampolines do, when set to nil?  The doc string says
>
>   If non-nil enable primitive trampoline synthesis.
>   This makes primitive functions redefinable or advisable effectively.
>
> which seems to hint that when this is nil, primitives cannot be
> advised or redefined?

They can, but they will not take effect on Lisp code that is native
compiled (at speed 2), similarly to when they are called from C code.

> We set this variable to nil in startup.el if
> native-comp-available-p returns nil (which currently can only happen
> on MS-Windows), AFAIU with the intent to prevent Emacs from even
> trying to natively-compile anything, including trampolines.  But if
> Emacs cannot produce a trampoline, it means that primitives cannot be
> redefined, and we silently fail that?  Because (again, AFAIU)
> native-comp-available-p being nil does not prevent Emacs from loading
> *.eln files that are already compiled (because just loading them
> doesn't need libgccjit), is that right?

Correct, as you said Emacs will work, only we can't guarantee that
primitive redefinition will take the effect expected by the user (unless
of course trampolines were precompiled, in that case it's all good).

Bests

  Andrea





  reply	other threads:[~2022-10-14 20:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  7:21 bug#58429: 29.0.50; inhibit-automatic-native-compilation does not work as expected Max Brieiev
2022-10-11  8:11 ` Lars Ingebrigtsen
2022-10-11  9:19   ` Max Brieiev
2022-10-11 19:37     ` Andrea Corallo
2022-10-11 19:41       ` Lars Ingebrigtsen
2022-10-11 20:49         ` Andrea Corallo
2022-10-12 10:57           ` Lars Ingebrigtsen
2022-10-12 11:15             ` Max Brieiev
2022-10-12 11:30               ` Lars Ingebrigtsen
2022-10-12 11:57                 ` Max Brieiev
2022-10-12 12:59                   ` Lars Ingebrigtsen
2022-10-12 13:31                   ` Eli Zaretskii
2022-10-12 14:11                     ` Max Brieiev
2022-10-12 15:32                       ` Eli Zaretskii
2022-10-12 16:54                         ` Max Brieiev
2022-10-12 17:07                           ` Eli Zaretskii
2022-10-13 14:10                           ` Andrea Corallo
2022-10-13 16:05                             ` Eli Zaretskii
2022-10-14 20:10                               ` Andrea Corallo [this message]
2022-10-15  9:17                                 ` Eli Zaretskii
2022-10-15 16:01                                   ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjf5ygmyxm6.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=58429@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=max.brieiev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).