From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44676: [PATCH 3/4] Support native compilation of packages on install Date: Fri, 20 Nov 2020 09:06:23 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44676@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 20 10:07:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kg2Np-0006TL-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 10:07:09 +0100 Original-Received: from localhost ([::1]:48754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg2No-0006lk-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 04:07:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg2Ni-0006lc-Ov for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 04:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kg2Ni-0006hM-IG for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 04:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kg2Ni-0003Ac-IC for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 04:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Nov 2020 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44676-submit@debbugs.gnu.org id=B44676.160586318612143 (code B ref 44676); Fri, 20 Nov 2020 09:07:02 +0000 Original-Received: (at 44676) by debbugs.gnu.org; 20 Nov 2020 09:06:26 +0000 Original-Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg2N7-00039n-O5 for submit@debbugs.gnu.org; Fri, 20 Nov 2020 04:06:25 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:51388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg2N6-00039f-1q for 44676@debbugs.gnu.org; Fri, 20 Nov 2020 04:06:24 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AK96NYl024756; Fri, 20 Nov 2020 09:06:23 GMT In-Reply-To: (Stefan Kangas's message of "Thu, 19 Nov 2020 14:34:52 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193775 Archived-At: Stefan Kangas writes: > From bd570f03a3b3dcb546b02e83faf263f27e82d05c Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Thu, 19 Nov 2020 22:11:17 +0100 > Subject: [PATCH 3/4] * lisp/emacs-lisp/comp.el (native-compile-async): Doc > fix. > > --- > lisp/emacs-lisp/comp.el | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index a9a07535a4..e48a1cfc18 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -3489,13 +3489,28 @@ batch-byte-native-compile-for-bootstrap > (defun native-compile-async (paths &optional recursively load) > "Compile PATHS asynchronously. > PATHS is one path or a list of paths to files or directories. > -`comp-async-jobs-number' specifies the number of (commands) to > -run simultaneously. If RECURSIVELY, recurse into subdirectories > -of given directories. > -LOAD can be nil t or 'late." > + > +If optional argument RECURSIVELY is non-nil, recurse into > +subdirectories of given directories. > + > +If optional argument LOAD is non-nil, request to load the file > +after compiling. > + > +The variable `comp-async-jobs-number' specifies the number > +of (commands) to run simultaneously. > + > +LOAD can also be the symbol `late'. This is used internally if > +the byte code has already been loaded when this function is > +called. It means that we requests the special kind of load, > +necessary in that situation, called \"late\" loading. > + > +During a \"late\" load instead of executing all top level forms > +of the original files, only function definitions are > +loaded (paying attention to have these effective only if the > +bytecode definition was not changed in the meanwhile)." > (comp-ensure-native-compiler) > (unless (member load '(nil t late)) > - (error "LOAD must be nil t or 'late")) > + (error "LOAD must be nil, t or 'late")) > (unless (listp paths) > (setf paths (list paths))) > (let (files) LGTM thanks for the nice clean-up