* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
@ 2020-12-23 1:59 gliao.tw--- via
2020-12-23 7:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 8+ messages in thread
From: gliao.tw--- via @ 2020-12-23 1:59 UTC (permalink / raw)
To: 45376; +Cc: emacs-devel@gnu.org
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Hi,
I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
The first attachment shows the `ls` command output under eshell loaded from elc, while the second attachment shows the same command, but much stranger output under eshell loaded from eln.
I have tested/complied the last updated code on Linux/x86-64, Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all the test cases generate the same weird output from `ls` under eln-loaded eshell.
This issue does not happen on the code based at or before commit f244c21902
Thanks,
Kiong-Ge.
[-- Attachment #2: eshell-use-byte-code.png --]
[-- Type: image/png, Size: 21481 bytes --]
[-- Attachment #3: eshell-use-native-comp-eln.png --]
[-- Type: image/png, Size: 43043 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 1:59 bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln gliao.tw--- via
@ 2020-12-23 7:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 15:34 ` gliao.tw--- via
0 siblings, 2 replies; 8+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-12-23 7:51 UTC (permalink / raw)
To: gliao.tw; +Cc: 45376
"gliao.tw@pm.me" <gliao.tw@pm.me> writes:
> Hi,
>
> I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
>
> The first attachment shows the `ls` command output under eshell loaded
> from elc, while the second attachment shows the same command, but much
> stranger output under eshell loaded from eln.
>
> I have tested/complied the last updated code on Linux/x86-64,
> Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> the test cases generate the same weird output from `ls` under
> eln-loaded eshell.
>
> This issue does not happen on the code based at or before commit f244c21902
>
> Thanks,
> Kiong-Ge.
Hi Kiong-Ge,
yep, I've merged a lot of stuff into the value/type inference logic so
this is certanly related.
The offending function is `eshell-ls-find-column-lengths', I'll have a
look.
Thanks for reporting
Andrea
PS leaving out emacs-devel to avoid cross posting
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 7:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-12-23 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 17:10 ` gliao.tw--- via
2020-12-23 15:34 ` gliao.tw--- via
1 sibling, 1 reply; 8+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-12-23 15:27 UTC (permalink / raw)
To: 45376; +Cc: gliao.tw
Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> "gliao.tw@pm.me" <gliao.tw@pm.me> writes:
>
>> Hi,
>>
>> I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
>>
>> The first attachment shows the `ls` command output under eshell loaded
>> from elc, while the second attachment shows the same command, but much
>> stranger output under eshell loaded from eln.
>>
>> I have tested/complied the last updated code on Linux/x86-64,
>> Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
>> the test cases generate the same weird output from `ls` under
>> eln-loaded eshell.
>>
>> This issue does not happen on the code based at or before commit f244c21902
>>
>> Thanks,
>> Kiong-Ge.
>
> Hi Kiong-Ge,
>
> yep, I've merged a lot of stuff into the value/type inference logic so
> this is certanly related.
>
> The offending function is `eshell-ls-find-column-lengths', I'll have a
> look.
Hi Kiong-Ge,
as of ffcd490cb4 is working for me, could you give it a try?
Just remember you might need to clean the eln-cache folder to have
eshell freshly recompiled.
Thanks!
Andrea
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 7:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-12-23 15:34 ` gliao.tw--- via
1 sibling, 0 replies; 8+ messages in thread
From: gliao.tw--- via @ 2020-12-23 15:34 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 45376
Indeed. On f244c21902, I got
~ $ (eshell-ls-find-column-lengths (list (list "dd" "kk") (list "rr" "uue")))
([4 4]
("dd" "kk")
("rr" "uue"))
but on 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111, I got
~ $ (eshell-ls-find-column-lengths (list (list "dd" "kk") (list "rr" "uue")))
([4 0]
("dd" "kk")
("dd" "kk"))
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, December 23, 2020 1:51 AM, Andrea Corallo <akrl@sdf.org> wrote:
> %22gliao.tw@pm.me">--protonSignature--"gliao.tw@pm.me" gliao.tw@pm.me writes:
>
> > Hi,
> > I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
> > The first attachment shows the `ls` command output under eshell loaded
> > from elc, while the second attachment shows the same command, but much
> > stranger output under eshell loaded from eln.
> > I have tested/complied the last updated code on Linux/x86-64,
> > Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> > the test cases generate the same weird output from `ls` under
> > eln-loaded eshell.
> > This issue does not happen on the code based at or before commit f244c21902
> > Thanks,
> > Kiong-Ge.
>
> Hi Kiong-Ge,
>
> yep, I've merged a lot of stuff into the value/type inference logic so
> this is certanly related.
>
> The offending function is `eshell-ls-find-column-lengths', I'll have a
> look.
>
> Thanks for reporting
>
> Andrea
>
> PS leaving out emacs-devel to avoid cross posting
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-12-23 17:10 ` gliao.tw--- via
2020-12-23 18:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 8+ messages in thread
From: gliao.tw--- via @ 2020-12-23 17:10 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 45376
Hi Andrea,
I can confirm that this issue is resolved by commit ffcd490cb4 on the following platforms (all using GCC 10.2):
Linux (Debian testing) Amd64 and Arm64
FreeBSD 12.2 Amd64, gcc build from ports
Windows/Msys2 as 2020-12-16
I believe we can close this bug now.
Thanks,
Gong-Yi.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, December 23, 2020 9:27 AM, Andrea Corallo <akrl@sdf.org> wrote:
> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" bug-gnu-emacs@gnu.org writes:
>
> > "gliao.tw@pm.me" gliao.tw@pm.me writes:
> >
> > > Hi,
> > > I checked the last updated feature/native-comp branch (commit 433ae7b0a5cedbcd7b0a1daf12846e38f00fd111) and identified a strange outputs from eln-compiled eshell.
> > > The first attachment shows the `ls` command output under eshell loaded
> > > from elc, while the second attachment shows the same command, but much
> > > stranger output under eshell loaded from eln.
> > > I have tested/complied the last updated code on Linux/x86-64,
> > > Linux/aarch64 (Debian Bullseye, GCC 10.2.1) and Windows (Msys2), all
> > > the test cases generate the same weird output from `ls` under
> > > eln-loaded eshell.
> > > This issue does not happen on the code based at or before commit f244c21902
> > > Thanks,
> > > Kiong-Ge.
> >
> > Hi Kiong-Ge,
> > yep, I've merged a lot of stuff into the value/type inference logic so
> > this is certanly related.
> > The offending function is `eshell-ls-find-column-lengths', I'll have a
> > look.
>
> Hi Kiong-Ge,
>
> as of ffcd490cb4 is working for me, could you give it a try?
>
> Just remember you might need to clean the eln-cache folder to have
> eshell freshly recompiled.
>
> Thanks!
>
> Andrea
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 17:10 ` gliao.tw--- via
@ 2020-12-23 18:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-25 5:59 ` Lars Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-12-23 18:51 UTC (permalink / raw)
To: gliao.tw; +Cc: 45376
"gliao.tw@pm.me" <gliao.tw@pm.me> writes:
> Hi Andrea,
>
> I can confirm that this issue is resolved by commit ffcd490cb4 on the following platforms (all using GCC 10.2):
>
> Linux (Debian testing) Amd64 and Arm64
> FreeBSD 12.2 Amd64, gcc build from ports
> Windows/Msys2 as 2020-12-16
>
> I believe we can close this bug now.
>
> Thanks,
> Gong-Yi.
Very nice, closing then.
Thanks!
Andrea
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-23 18:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-12-25 5:59 ` Lars Ingebrigtsen
2020-12-25 8:01 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-25 5:59 UTC (permalink / raw)
To: Andrea Corallo; +Cc: gliao.tw, 45376
Andrea Corallo <akrl@sdf.org> writes:
> Very nice, closing then.
The bug was apparently not closed? :-) So I'm doing that now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln
2020-12-25 5:59 ` Lars Ingebrigtsen
@ 2020-12-25 8:01 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 8+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-12-25 8:01 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: gliao.tw, 45376
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Very nice, closing then.
>
> The bug was apparently not closed? :-) So I'm doing that now.
Ops, thanks :)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-25 8:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-23 1:59 bug#45376: 28.0.50; [Feature/Native-Comp] strange `ls` output in eshell loaded from eln gliao.tw--- via
2020-12-23 7:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 15:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 17:10 ` gliao.tw--- via
2020-12-23 18:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-25 5:59 ` Lars Ingebrigtsen
2020-12-25 8:01 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-23 15:34 ` gliao.tw--- via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).