From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows Date: Wed, 20 May 2020 17:24:31 +0000 Message-ID: References: <83k11e4a0s.fsf@gnu.org> <83blmp4tob.fsf@gnu.org> <83o8qp1hfr.fsf@gnu.org> <837dxcv1po.fsf@gnu.org> <83imgvdf94.fsf@gnu.org> <83eerjde6k.fsf@gnu.org> <838shm7g9m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="40490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41242@debbugs.gnu.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 19:25:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbSSy-000AQ3-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 19:25:16 +0200 Original-Received: from localhost ([::1]:60926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbSSy-0000DZ-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 13:25:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbSSk-0008Ue-NX for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 13:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbSSk-0003Ml-DL for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 13:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbSSk-0001GA-9I for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 13:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.15899954744801 (code B ref 41242); Wed, 20 May 2020 17:25:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 20 May 2020 17:24:34 +0000 Original-Received: from localhost ([127.0.0.1]:54186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbSSI-0001FM-Fh for submit@debbugs.gnu.org; Wed, 20 May 2020 13:24:34 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:57933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbSSH-0001FE-7f for 41242@debbugs.gnu.org; Wed, 20 May 2020 13:24:33 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04KHOVrD006312 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 20 May 2020 17:24:31 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04KHOVww008693; Wed, 20 May 2020 17:24:31 GMT In-Reply-To: ("Nicolas =?UTF-8?Q?B=C3=A9rtolo?="'s message of "Wed, 20 May 2020 13:17:54 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180675 Archived-At: Nicolas B=C3=A9rtolo writes: >> Thanks, I'll start going through them this evening I guess in patch >> chronological order. Ok this is in: 68fad7a8fc @ Do not block SIGIO in platforms that don't have it. Looking at 0003-Handle-setjmp-taking-two-arguments-in-Windows.patch > +static void > +define_setjmp_deps (void) > +{ > + comp.setjmp_ctx_func > + =3D gcc_jit_context_get_builtin_function (comp.ctxt, > + "__builtin_frame_address"); > +} This won't compile on Posix because setjmp_ctx_func is under #ifdef _WIN32. Given setjmp_ctx_func is used only in emit_setjmp I suggest to invoke directly gcc_jit_context_get_builtin_function there while emitting the corresponding call. The following patches do not currently apply, please update them from your rebase branch: 0004-Handle-LISP_WORDS_ARE_POINTERS-and-CHECK_LISP_OBJECT.patch 0005-Remove-a-layer-of-indirection-for-access-to-pure-sto.patch While you are refreshing patches please have a look into the GNU style of the diff (spaces in function calls and in pointer declaration) ;) Thanks Andrea --=20 akrl@sdf.org