From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#38072: when `byte-compile-file' finds out that a file is `no-byte-compile', it ignores `load' parameter Date: Mon, 07 Sep 2020 16:44:10 +0000 Message-ID: References: <834kocrbg1.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Eli Zaretskii , 38072@debbugs.gnu.org, Stefan Monnier , pogonyshev@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 18:45:39 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKGw-00091X-Qh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 18:45:38 +0200 Original-Received: from localhost ([::1]:56544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFKGv-0006mx-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 12:45:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFKGM-0005wQ-TF for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFKGM-0000dI-IR for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFKGM-0003RH-C0 for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38072-submit@debbugs.gnu.org id=B38072.159949705313150 (code B ref 38072); Mon, 07 Sep 2020 16:45:02 +0000 Original-Received: (at 38072) by debbugs.gnu.org; 7 Sep 2020 16:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:50629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKFZ-0003Q1-9z for submit@debbugs.gnu.org; Mon, 07 Sep 2020 12:44:13 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:64833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKFX-0003Pt-HE for 38072@debbugs.gnu.org; Mon, 07 Sep 2020 12:44:12 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 087GiAIm027033; Mon, 7 Sep 2020 16:44:10 GMT In-Reply-To: (Stefan Kangas's message of "Mon, 7 Sep 2020 09:37:29 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187454 Archived-At: Stefan Kangas writes: > Stefan Monnier writes: > >> FWIW, I find the "and load" feature to be a mistake: the function should >> return whether or not it successfully compiled the file, but shouldn't >> offer to load the result, since the callers can just as easily do >> it themselves (and then they can easily control what happens when >> compilation did not succeed). >> So, I'd suggest we deprecate that "feature" rather than try and decide >> which behavior is better. > > It's pretty convenient when running interactively though. I've tried > using `C-u M-x byte-compile-file' (instead of my usual eval-buffer) for > the last couple of days, and I kind of like getting both > byte-compilation and load-file in one command. > > But if we do deprecate this, is there a better alternative that we can > point users to? Should we just tell them to run two commands? Hi Stefan, would having the load performed by `emacs-lisp-byte-compile-and-load' an option? Ciao Andrea