From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gongyi.liao@gmail.com, 45303@debbugs.gnu.org
Subject: bug#45303: 28.0.50; [feature/native-comp] comp.c compilation error on Windows 10
Date: Mon, 21 Dec 2020 09:48:01 +0000 [thread overview]
Message-ID: <xjf35zzv6b2.fsf@sdf.org> (raw)
In-Reply-To: <83r1nm6dre.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Dec 2020 22:49:25 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: 45303@debbugs.gnu.org, gongyi.liao@gmail.com,
>> =?UTF-8?Q?Li=C4=81u@debbugs.gnu.org
>> Date: Fri, 18 Dec 2020 16:37:31 +0000
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> Date: Fri, 18 Dec 2020 13:28:20 +0000
>> >> Cc: gongyi.liao@gmail.com, =?UTF-8?Q?Li=C4=81u@debbugs.gnu.org
>> >> From: Andrea Corallo via "Bug reports for GNU Emacs,
>> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> >>
>> >> >> CCLD temacs.exe
>> >> >> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>> >> >> comp.o: in function `md5_gz_stream':
>> >> >> C:\msys64\home\VWinUser0\Downloads\emacs\native-comp\build\src/../../src/src/comp.c:713:
>> >> >> undefined reference to `inflateInit2_'
>> >> >> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
>> >> >> C:\msys64\home\VWinUser0\Downloads\emacs\native-comp\build\src/../../src/src/comp.c:730:
>> >> >> undefined reference to `inflate'
>> >> >
>> >> > That's curious, looks you've not zlib but from the config.log you do...
>> >>
>> >> I really would like to understand what's going on here.
>> >>
>> >> We check in configure for zlib presence, actually this is also require
>> >> by --with-nativecomp but somehow the linker fails to find it.
>> >
>> > Why does the native-comp branch require zlib in comp.c? what does it
>> > do with zlib?
>>
>> We hash the content of the lisp source files to obtain the correspondent
>> eln name in the eln-cache.
>>
>> This machinery has to work since early bootstrap (and has to be fast
>> since is executed at each file load), so is directly done from comp.c.
>>
>> When Emacs is installed the el files are compressed and so before
>> hashing them we have to decompress therefore we use zlib.
>
> Thanks for the explanations.
>
>> > On master, zlib is an optional library, and when some Emacs command is
>> > invoked that needs it, on MS-Windows we load the zlib DLL at run time
>> > when requested. See init_zlib_functions in decompress.c. This is
>> > unlike on Posix systems, where Emacs is linked with zlib at link time.
>> > Does this explain what is going on?
>>
>> I see, we should probably have comp.c use the necessary DEF_DLL_FN bloat
>> or have these functions wrapped in decompress.c.
>
> I think it's better to use functions in decompress.c or add whatever
> you need there, and have the new functions use the same paradigm,
> which on Windows loads the DLL the first time it is needed.
Hi Eli,
so I did, with 5b10a0324d I moved 'md5_gz_stream' to decompress.c,
before running it we load zlib if necessary.
Hopefully this solves this part of the issue.
Thanks
Andrea
next prev parent reply other threads:[~2020-12-21 9:48 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 20:20 bug#45303: 28.0.50; [feature/native-comp] comp.c compilation error on Windows 10 =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-17 20:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-17 20:33 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-17 20:41 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-17 20:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-17 21:02 ` Eli Zaretskii
2020-12-17 21:10 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-17 21:27 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-17 21:41 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-18 13:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-18 16:06 ` Eli Zaretskii
2020-12-18 16:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-18 19:35 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-18 21:26 ` Eli Zaretskii
2020-12-19 0:57 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-19 5:38 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-19 8:04 ` Eli Zaretskii
2020-12-18 19:40 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-18 20:49 ` Eli Zaretskii
2020-12-21 9:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-12-19 17:56 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-18 11:13 ` bug#45303: #45303 [feature/native-comp] building error on Windows Pal Gloss
2020-12-18 16:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-18 21:22 ` Eli Zaretskii
2020-12-18 22:21 ` Pal Gloss
2020-12-19 7:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-19 14:35 ` Andy Moreton
2020-12-19 16:15 ` Eli Zaretskii
2020-12-19 17:15 ` Andy Moreton
2020-12-19 17:37 ` Eli Zaretskii
2020-12-19 21:39 ` Andy Moreton
2020-12-19 18:07 ` Pal Gloss
2020-12-19 20:40 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-20 11:22 ` Andy Moreton
2020-12-20 18:58 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-20 19:11 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-21 0:53 ` Andy Moreton
2020-12-21 8:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-21 8:09 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-21 17:41 ` Andy Moreton
2020-12-20 16:23 ` Pal Gloss
2020-12-20 19:07 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-21 10:10 ` Pal Gloss
2020-12-21 12:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-21 22:46 ` Andy Moreton
2020-12-22 8:47 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-22 19:41 ` Andy Moreton
2020-12-21 16:21 ` Eli Zaretskii
2020-12-18 22:25 ` Pal Gloss
2020-12-19 19:08 ` bug#45303: #45303 [feature/native-comp] building error on Windows ... strsignal in msys2/mingw64 Pal Gloss
2020-12-19 19:29 ` Eli Zaretskii
2020-12-20 16:15 ` Pal Gloss
2020-12-19 23:04 ` bug#45303: 28.0.50; [feature/native-comp] comp.c compilation error on Windows 10 =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-20 2:31 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-20 8:38 ` Michael Albinus
2020-12-20 9:49 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-20 19:10 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-20 19:46 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-20 20:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-20 16:32 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-21 18:02 ` =?UTF-8?Q?Li=C4=81u, _?= Kiong-Gē 廖宮毅
2020-12-22 15:47 ` bug#45303: #45303 [feature/native-comp] building error on Windows gliao.tw--- via
2020-12-22 19:15 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-22 19:48 ` gliao.tw--- via
2020-12-22 20:09 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-22 20:15 ` gliao.tw--- via
2020-12-22 20:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-22 20:39 ` Eli Zaretskii
2020-12-23 7:01 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-26 14:02 ` edouard debry
2020-12-26 14:24 ` Eli Zaretskii
2020-12-26 14:58 ` edouard debry
2020-12-26 15:12 ` Eli Zaretskii
2021-01-06 20:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-12-22 19:46 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjf35zzv6b2.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=45303@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
--cc=gongyi.liao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).