From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46617: 28.0.50; nativecomp: native compile cache is not invalidated when file is re-byte compiled and changes Date: Sun, 21 Mar 2021 17:59:23 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18979"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46617@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 19:01:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lO2O9-0004q5-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 19:01:21 +0100 Original-Received: from localhost ([::1]:50852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lO2O8-0001wJ-Na for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 14:01:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO2Mt-0001u4-Io for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:00:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lO2Mt-0007v7-C6 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lO2Mt-0003bP-At for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 18:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46617 X-GNU-PR-Package: emacs Original-Received: via spool by 46617-submit@debbugs.gnu.org id=B46617.161634956813735 (code B ref 46617); Sun, 21 Mar 2021 18:00:03 +0000 Original-Received: (at 46617) by debbugs.gnu.org; 21 Mar 2021 17:59:28 +0000 Original-Received: from localhost ([127.0.0.1]:55473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO2MJ-0003ZT-V5 for submit@debbugs.gnu.org; Sun, 21 Mar 2021 13:59:28 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:62395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO2MI-0003ZI-3w for 46617@debbugs.gnu.org; Sun, 21 Mar 2021 13:59:26 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12LHxNVW027703 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 21 Mar 2021 17:59:24 GMT In-Reply-To: (Aaron Jensen's message of "Sun, 21 Mar 2021 12:36:39 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202795 Archived-At: Aaron Jensen writes: > On Sun, Mar 21, 2021 at 12:27 PM Andrea Corallo wrote: >> >> Hi Aaron, >> >> I had to slightly modify your init.el reproducer as we have changed the >> semantic of `load' [1]. > > With this change, how do you specify that you want the eln to load if > it's there? If I understand correctly, this prevents loading the eln > with load unless it is specified explicitly? Or can you leave the > extension off when loading and that will prefer the eln, then elc, > then el? Exactly load by default tries to add the extentions to the FILE argument. >> I think what happened is that in the original reproducer the second load >> of the .elc file still automatically loaded in place the corresponding >> .eln as the source file didn't changed. The issue here is that in the >> compilation unit repro.elk is capturing some of the environment and this >> is not accounted in the hash computation of the .eln file. > > The original repro simulated a restart without a restart. The real bug > (in straight.el) is that on start, it loads a byte compiled/native > compiled file that relies on outside environment. So, that may be > fixed now because I believe they load the elc explicitly, but that > means it'll never load the native compiled version. Ideally, they > would, but I don't know how to force loading byte compiled OR native > compiled in one command. ATM to force the byte-code version to be used one can use `load' making the .elc extension explicit (or without using the extension binding `load-no-native' to non-nil). To explicitly force load the native code version one has to do like: (load (comp-el-to-eln-filename ".../foo.el")) But this is limited as it works only if the .eln is in the first directory of `com-eln-load-path', so probably we have to offer a more complete solution. >> The new reproducer (well it does not reproduce much :) ) works because >> now `load' called explicitly on a .elc file does not load automatically >> the corresponding .eln. Alternatively to overcome the issue still using >> native compilation one has to force a new native compilation using >> `native-compile. WDYT? > > I think it sounds like straight.el will need to add detection for > native compilation, and any time they byte compile, also native > compile. I also think that this is extremely fragile and I wonder if > byte compiling should result in "invalidating" (deleting) the > previously corresponding eln. We essentially have a cache invalidation > that is relying purely on a cache key that is incomplete. Mmhh maybe it's a good idea. The other option would be to re-introduce the constrain that, to be used in place, the .eln must be younger than the .elc. Thanks Andrea