bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc

[Leo <sdl.web@gmail.com>]

On 2009-10-18 04:43 +0100, Ryan Yeske wrote:
> Hi,
>
> If I remember correctly, it used to be the case that only mouse-2
> visited hyperlinks in emacs buffers.  Is it standard for mouse-1 to do
> this now?  Should I just change the binding, or duplicate it?
>
> Ryan

On 2009-10-18 05:35 +0100, Chong Yidong wrote:
> Ryan Yeske <rcyeske@gmail.com> writes:
>
>> If I remember correctly, it used to be the case that only mouse-2
>> visited hyperlinks in emacs buffers.  Is it standard for mouse-1 to do
>> this now?  Should I just change the binding, or duplicate it?
>
> Use the "follow-link" functionality.  See the "Defining Clickable Text"
> node in the Emacs Lisp manual; you can look at the way other Emacs modes
> do it for examples.

I tested the following patch and it seems to work correctly.

diff -c -L /Users/admin/lisp/lisp/net/rcirc.el.gz~ -L /Users/admin/lisp/lisp/net/rcirc.el.gz /tmp/jka-com5634zYF /tmp/jka-com5634NtR
--- /Users/admin/lisp/lisp/net/rcirc.el.gz~
+++ /Users/admin/lisp/lisp/net/rcirc.el.gz
@@ -835,7 +835,8 @@
   "Keymap used for browsing URLs in `rcirc-mode'.")

 (define-key rcirc-browse-url-map (kbd "RET") 'rcirc-browse-url-at-point)
 (define-key rcirc-browse-url-map (kbd "<mouse-2>") 'rcirc-browse-url-at-mouse)
+(define-key rcirc-browse-url-map [follow-link] 'mouse-face)

 (defvar rcirc-short-buffer-name nil
   "Generated abbreviation to use to indicate buffer activity.")

Diff finished.  Thu Dec 24 00:41:00 2009